From nobody Tue May 7 15:00:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628794792; cv=none; d=zohomail.com; s=zohoarc; b=ZX9DVT5YQRN4Dnlmu8BLrOR+GG7b17PItYuxuUl/srz3DQ6nQFgAm8ICTFma/8qBjTgFmfoPAuInqJSPf8OqpE+CN2JTI1HjH1EhppB4EiJxH6fddfW/UVyjx7ea3JXo1v0RQH+Ck7M+NxhbGS9MrYJe59a5ERvZ+0yduH5T6TE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628794792; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=dANB39EILNHt++G5osUiH8DokKYglX4gL8rQG59z74Y=; b=ANhZ5V8S5+V2Bc01HVo4LPsmfNisg5EBv1kQVxWXe3M/oSqP5KGEqrRy8u9aZWNWi5h2TYeRrjW32cYSwWqdOJVeCxtsmLdLSfmdGxl6oRtZx1TdMmUG+++wcc4kG7YVsNWiVXLGrbDqSCkhQQPA5Z61tUGViy8RvLXUek1+oyA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1628794792050200.6723239558496; Thu, 12 Aug 2021 11:59:52 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-_XiQwqjcMmmrLGEDfCU6Yg-1; Thu, 12 Aug 2021 14:59:49 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1AFA18C8C00; Thu, 12 Aug 2021 18:59:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 202271AC7E; Thu, 12 Aug 2021 18:59:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AC710181A0F2; Thu, 12 Aug 2021 18:59:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17CIxSlB007275 for ; Thu, 12 Aug 2021 14:59:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id D4EC8669ED; Thu, 12 Aug 2021 18:59:28 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.40.192.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8BCC1BCF0 for ; Thu, 12 Aug 2021 18:59:25 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 1D3A0246BBB; Thu, 12 Aug 2021 18:59:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628794791; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dANB39EILNHt++G5osUiH8DokKYglX4gL8rQG59z74Y=; b=XEFwBFekjX+UKLtmNm4+D6KFRa6UBKjQjMcWoWbLY8etYc9evMlkCGF4Wczv/A1e+x2bfk wMNeocTPcNrGd141vQETuagNJ3tH+3sPmaEt5mW5YvxD4sgOCSW9OhYEDHlDecYUuKUG6J VgBKAG16hy0BRukTHtA2Prg2oqdc040= X-MC-Unique: _XiQwqjcMmmrLGEDfCU6Yg-1 From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] util: Fix memory leak when clearing Open vSwitch QoS Date: Thu, 12 Aug 2021 18:59:08 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628794793851100001 Content-Type: text/plain; charset="utf-8" No need to overwrite vmid_ex_id with a pointer to another copy of the same string when the original is still alive. Signed-off-by: Jiri Denemark Reviewed-by: J=C3=A1n Tomko --- src/util/virnetdevopenvswitch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitc= h.c index 7a64a8dbe6..f6a8ed4a31 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -824,7 +824,6 @@ virNetDevOpenvswitchInterfaceClearQos(const char *ifnam= e, /* find queue */ virCommandFree(cmd); cmd =3D virNetDevOpenvswitchCreateCmd(); - vmid_ex_id =3D g_strdup_printf("external-ids:vm-id=3D\"%s\"", vmuuidst= r); virCommandAddArgList(cmd, "--no-heading", "--columns=3D_uuid", "find",= "queue", vmid_ex_id, NULL); virCommandSetOutputBuffer(cmd, &queue_uuid); if (virCommandRun(cmd, NULL) < 0) { --=20 2.32.0