From nobody Sun Feb 8 13:16:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571059043; cv=none; d=zoho.com; s=zohoarc; b=ohE33wX0vesho+sJuxqPczAf0qfaIvWjlz7R3726F39YKWcwKcKtiJzG3PymOmmv4vlewrf7E8rLjyPdQ47Y/2kriWsFiLGZ8TuOJxtG+z+pK6ZHMahfbujVtEC8ylYiKezm78SCbtoM7A4Qohb2530OCus9NwFBjjJWlW0C2Ss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571059043; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UzuRFwJ25bI+hME/VpgoBiq99x6I5u0DQVYpHMLww8A=; b=oaP8TLbdP5WdaSN57feREFgu4fzGzid8I+h8NNsrxsOFL/Z9TYUiHEfwKm04U24LQyHCFHAJ+C2yD135/KuKb4c6b/K7IcpjaatpiE4FaylIOQW8Y++pKUnGwTz3dxs1FqAe37e+vDXrEp0vNH6TAEr5Q/QFkusFdHI++j/xd2A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571059043154147.48058627514956; Mon, 14 Oct 2019 06:17:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 02337308404F; Mon, 14 Oct 2019 13:17:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C83805D784; Mon, 14 Oct 2019 13:17:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7E2814EEBD; Mon, 14 Oct 2019 13:17:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9EDGTSm017470 for ; Mon, 14 Oct 2019 09:16:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id 724076012C; Mon, 14 Oct 2019 13:16:29 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEC86600CD for ; Mon, 14 Oct 2019 13:16:28 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 14 Oct 2019 15:15:37 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 19/35] nwfilter: use G_GNUC_UNUSED X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 14 Oct 2019 13:17:22 +0000 (UTC) Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED. Signed-off-by: J=C3=A1n Tomko --- src/nwfilter/nwfilter_dhcpsnoop.c | 20 ++++++++++---------- src/nwfilter/nwfilter_driver.c | 22 +++++++++++----------- src/nwfilter/nwfilter_ebiptables_driver.c | 12 ++++++------ src/nwfilter/nwfilter_gentech_driver.c | 2 +- src/nwfilter/nwfilter_learnipaddr.c | 12 ++++++------ 5 files changed, 34 insertions(+), 34 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcp= snoop.c index c82457989e..dae2ad611d 100644 --- a/src/nwfilter/nwfilter_dhcpsnoop.c +++ b/src/nwfilter/nwfilter_dhcpsnoop.c @@ -661,7 +661,7 @@ virNWFilterSnoopReqUnlock(virNWFilterSnoopReqPtr req) * virNWFilterSnoopReqRelease - hash table free function to kill a request */ static void -virNWFilterSnoopReqRelease(void *req0, const void *name ATTRIBUTE_UNUSED) +virNWFilterSnoopReqRelease(void *req0, const void *name G_GNUC_UNUSED) { virNWFilterSnoopReqPtr req =3D req0; =20 @@ -1826,8 +1826,8 @@ virNWFilterSnoopLeaseFileSave(virNWFilterSnoopIPLease= Ptr ipl) */ static int virNWFilterSnoopPruneIter(const void *payload, - const void *name ATTRIBUTE_UNUSED, - const void *data ATTRIBUTE_UNUSED) + const void *name G_GNUC_UNUSED, + const void *data G_GNUC_UNUSED) { virNWFilterSnoopReqPtr req =3D (virNWFilterSnoopReqPtr)payload; bool del_req; @@ -1856,7 +1856,7 @@ virNWFilterSnoopPruneIter(const void *payload, */ static int virNWFilterSnoopSaveIter(void *payload, - const void *name ATTRIBUTE_UNUSED, + const void *name G_GNUC_UNUSED, void *data) { virNWFilterSnoopReqPtr req =3D payload; @@ -2023,8 +2023,8 @@ virNWFilterSnoopJoinThreads(void) */ static int virNWFilterSnoopRemAllReqIter(const void *payload, - const void *name ATTRIBUTE_UNUSED, - const void *data ATTRIBUTE_UNUSED) + const void *name G_GNUC_UNUSED, + const void *data G_GNUC_UNUSED) { virNWFilterSnoopReqPtr req =3D (virNWFilterSnoopReqPtr)payload; =20 @@ -2200,7 +2200,7 @@ virNWFilterDHCPSnoopInit(void) } =20 void -virNWFilterDHCPSnoopEnd(const char *ifname ATTRIBUTE_UNUSED) +virNWFilterDHCPSnoopEnd(const char *ifname G_GNUC_UNUSED) { return; } @@ -2212,9 +2212,9 @@ virNWFilterDHCPSnoopShutdown(void) } =20 int -virNWFilterDHCPSnoopReq(virNWFilterTechDriverPtr techdriver ATTRIBUTE_UNUS= ED, - virNWFilterBindingDefPtr binding ATTRIBUTE_UNUSED, - virNWFilterDriverStatePtr driver ATTRIBUTE_UNUSED) +virNWFilterDHCPSnoopReq(virNWFilterTechDriverPtr techdriver G_GNUC_UNUSED, + virNWFilterBindingDefPtr binding G_GNUC_UNUSED, + virNWFilterDriverStatePtr driver G_GNUC_UNUSED) { virReportError(VIR_ERR_INTERNAL_ERROR, _("libvirt was not compiled with libpcap and \"" diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index aef5bd4c7f..fbdf250934 100644 --- a/src/nwfilter/nwfilter_driver.c +++ b/src/nwfilter/nwfilter_driver.c @@ -80,9 +80,9 @@ static void nwfilterDriverUnlock(void) #ifdef WITH_FIREWALLD =20 static DBusHandlerResult -nwfilterFirewalldDBusFilter(DBusConnection *connection ATTRIBUTE_UNUSED, +nwfilterFirewalldDBusFilter(DBusConnection *connection G_GNUC_UNUSED, DBusMessage *message, - void *user_data ATTRIBUTE_UNUSED) + void *user_data G_GNUC_UNUSED) { if (dbus_message_is_signal(message, DBUS_INTERFACE_DBUS, "NameOwnerChanged") || @@ -154,7 +154,7 @@ nwfilterDriverRemoveDBusMatches(void) } =20 static int -nwfilterDriverInstallDBusMatches(DBusConnection *sysbus ATTRIBUTE_UNUSED) +nwfilterDriverInstallDBusMatches(DBusConnection *sysbus G_GNUC_UNUSED) { return 0; } @@ -177,8 +177,8 @@ virNWFilterTriggerRebuildImpl(void *opaque) */ static int nwfilterStateInitialize(bool privileged, - virStateInhibitCallback callback ATTRIBUTE_UNUSED, - void *opaque ATTRIBUTE_UNUSED) + virStateInhibitCallback callback G_GNUC_UNUSED, + void *opaque G_GNUC_UNUSED) { DBusConnection *sysbus =3D NULL; =20 @@ -384,8 +384,8 @@ nwfilterStateCleanup(void) =20 static virDrvOpenStatus nwfilterConnectOpen(virConnectPtr conn, - virConnectAuthPtr auth ATTRIBUTE_UNUSED, - virConfPtr conf ATTRIBUTE_UNUSED, + virConnectAuthPtr auth G_GNUC_UNUSED, + virConfPtr conf G_GNUC_UNUSED, unsigned int flags) { virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); @@ -409,27 +409,27 @@ nwfilterConnectOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } =20 -static int nwfilterConnectClose(virConnectPtr conn ATTRIBUTE_UNUSED) +static int nwfilterConnectClose(virConnectPtr conn G_GNUC_UNUSED) { return 0; } =20 =20 -static int nwfilterConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) +static int nwfilterConnectIsSecure(virConnectPtr conn G_GNUC_UNUSED) { /* Trivially secure, since always inside the daemon */ return 1; } =20 =20 -static int nwfilterConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) +static int nwfilterConnectIsEncrypted(virConnectPtr conn G_GNUC_UNUSED) { /* Not encrypted, but remote driver takes care of that */ return 0; } =20 =20 -static int nwfilterConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED) +static int nwfilterConnectIsAlive(virConnectPtr conn G_GNUC_UNUSED) { return 1; } diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfil= ter_ebiptables_driver.c index 32bbf6d05c..50db150151 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -616,9 +616,9 @@ iptablesLinkTmpRootChainsFW(virFirewallPtr fw, =20 =20 static void -iptablesSetupVirtInPostFW(virFirewallPtr fw ATTRIBUTE_UNUSED, - virFirewallLayer layer ATTRIBUTE_UNUSED, - const char *ifname ATTRIBUTE_UNUSED) +iptablesSetupVirtInPostFW(virFirewallPtr fw G_GNUC_UNUSED, + virFirewallLayer layer G_GNUC_UNUSED, + const char *ifname G_GNUC_UNUSED) { virFirewallAddRuleFull(fw, layer, true, NULL, NULL, @@ -2805,7 +2805,7 @@ static int ebtablesRenameTmpSubAndRootChainsQuery(virFirewallPtr fw, virFirewallLayer layer, const char *const *lines, - void *opaque ATTRIBUTE_UNUSED) + void *opaque G_GNUC_UNUSED) { size_t i; char newchain[MAX_CHAINNAME_LENGTH]; @@ -3759,8 +3759,8 @@ ebiptablesDriverProbeCtdir(void) =20 =20 static int -ebiptablesDriverProbeStateMatchQuery(virFirewallPtr fw ATTRIBUTE_UNUSED, - virFirewallLayer layer ATTRIBUTE_UNUS= ED, +ebiptablesDriverProbeStateMatchQuery(virFirewallPtr fw G_GNUC_UNUSED, + virFirewallLayer layer G_GNUC_UNUSED, const char *const *lines, void *opaque) { diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter= _gentech_driver.c index 6d68189d5f..d39f1ecb6d 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b/src/nwfilter/nwfilter_gentech_driver.c @@ -140,7 +140,7 @@ struct printString =20 =20 static int -printString(void *payload ATTRIBUTE_UNUSED, const void *name, void *data) +printString(void *payload G_GNUC_UNUSED, const void *name, void *data) { struct printString *ps =3D data; =20 diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_le= arnipaddr.c index 34b8d7fcd9..36bc3b06da 100644 --- a/src/nwfilter/nwfilter_learnipaddr.c +++ b/src/nwfilter/nwfilter_learnipaddr.c @@ -307,7 +307,7 @@ virNWFilterHasLearnReq(int ifindex) =20 =20 static void -freeLearnReqEntry(void *payload, const void *name ATTRIBUTE_UNUSED) +freeLearnReqEntry(void *payload, const void *name G_GNUC_UNUSED) { virNWFilterIPAddrLearnReqFree(payload); } @@ -764,11 +764,11 @@ virNWFilterLearnIPAddress(virNWFilterTechDriverPtr te= chdriver, #else =20 int -virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver ATTRIBUTE_UN= USED, - virNWFilterBindingDefPtr binding ATTRIBUTE_UNUSE= D, - int ifindex ATTRIBUTE_UNUSED, - virNWFilterDriverStatePtr driver ATTRIBUTE_UNUSE= D, - int howDetect ATTRIBUTE_UNUSED) +virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver G_GNUC_UNUSE= D, + virNWFilterBindingDefPtr binding G_GNUC_UNUSED, + int ifindex G_GNUC_UNUSED, + virNWFilterDriverStatePtr driver G_GNUC_UNUSED, + int howDetect G_GNUC_UNUSED) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("IP parameter must be given since libvirt " --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list