From nobody Fri May 10 03:53:32 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1698939711109583.2398099135476; Thu, 2 Nov 2023 08:41:51 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A38DC17F4; Thu, 2 Nov 2023 11:41:49 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0C32C17DB; Thu, 2 Nov 2023 11:40:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0CD5817DA; Thu, 2 Nov 2023 11:40:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 79F2917D6 for ; Thu, 2 Nov 2023 11:40:31 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-mrouxChLMR2qO5AuXHWisA-1; Thu, 02 Nov 2023 11:40:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94C4D28237CE for ; Thu, 2 Nov 2023 15:40:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C2731121308 for ; Thu, 2 Nov 2023 15:40:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Greylist: delayed 97604 seconds by postgrey-1.37 at lists.libvirt.org; Thu, 02 Nov 2023 11:40:31 EDT X-MC-Unique: mrouxChLMR2qO5AuXHWisA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH] virDomainDeviceInfoCheckABIStability: Implement proper check for CCW addresses Date: Thu, 2 Nov 2023 16:40:28 +0100 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 36XNU67YTRE7XBHORTNKAHQRTIGUG2ZL X-Message-ID-Hash: 36XNU67YTRE7XBHORTNKAHQRTIGUG2ZL X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1698939711518100001 CCW addresses need to be also checked for ABI stability. Signed-off-by: Peter Krempa Reviewed-by: Andrea Bolognani --- src/conf/domain_conf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 80f467ae7a..5ce1793c2d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19719,10 +19719,21 @@ virDomainDeviceInfoCheckABIStability(virDomainDev= iceInfo *src, } break; + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: + if (src->addr.ccw.cssid !=3D dst->addr.ccw.cssid || + src->addr.ccw.ssid !=3D dst->addr.ccw.ssid || + src->addr.ccw.devno !=3D dst->addr.ccw.devno) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target device CCW address %1$x.%2$x.%3$04x d= oes not match source %4$x.%5$x.%6$04x"), + dst->addr.ccw.cssid, dst->addr.ccw.ssid, dst->a= ddr.ccw.devno, + src->addr.ccw.cssid, src->addr.ccw.ssid, src->a= ddr.ccw.devno); + return false; + } + break; + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390: - case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED: --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org