From nobody Mon Feb 9 17:07:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617980464; cv=none; d=zohomail.com; s=zohoarc; b=EOKmOWzn4JyW/ufCVNyu0IV+fn9yzY5459l5vgq/UmLe5W7wCZNC7kfGke7drVQB7cF0zc8CSdqwJ1OS9s2/BMWz6qAnD8pzq+osS2nbUUJi97kzJRMrEIcDd3EQyI+ASspxZPTE+pYXCXFUNbX0XxdrMl3aGw8GjduuTLD0KVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617980464; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mAovM0q9uMri7RIrlHh8qeU+R8RzicGQnRoSbE75QG8=; b=YF4pbHEJCF8FCHWiSIbn2c1j+XdNqCsSLVtjDiy8EUNC0RoRdD4zsjXRbAl5PXa5dUwV78xmqhkFBepgNC3slYMWRiu7LQ8suko4kjfsq8edP8zIbCpJ9zyes+YlJb2wfP0HK503R8eS4LWaIu6tjHYcsE/qVJQHxlGatTc/kjk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617980464663470.4194730938134; Fri, 9 Apr 2021 08:01:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-TZZbJgFoNym7Zndy5wO1BA-1; Fri, 09 Apr 2021 11:00:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BAB05B392; Fri, 9 Apr 2021 15:00:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34A2F5D9C0; Fri, 9 Apr 2021 15:00:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D608518095C9; Fri, 9 Apr 2021 15:00:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 139EvgBf023794 for ; Fri, 9 Apr 2021 10:57:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id D657414106; Fri, 9 Apr 2021 14:57:42 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C1F460D79 for ; Fri, 9 Apr 2021 14:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617980462; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mAovM0q9uMri7RIrlHh8qeU+R8RzicGQnRoSbE75QG8=; b=X4Ml9XLeVCoxOdg5PlWiHXkivAxFzYFh8bn1HqoELZr1562EnLaDtUqAha0ptnK2BuroKA P7UiP0FTpgVEdHT+bVa5P1StCh3hU5z3t9wqS4wy7qvNXMOA3Vt73QPP8ClZBy+uN4InCC imn6hy2p1Ey8nXil338EvGuP+sl0g9o= X-MC-Unique: TZZbJgFoNym7Zndy5wO1BA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [RFC PATCH 14/43] virQEMUCapsInitProcessCaps: Remove obsolete version checks Date: Fri, 9 Apr 2021 16:56:50 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We no longer have to mask out IOMMU and NVDIMM support as we no longer support the broken qemu versions. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_capabilities.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e7ae174bcc..ec5fcc72b5 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5182,23 +5182,6 @@ virQEMUCapsInitProcessCapsInterlock(virQEMUCapsPtr q= emuCaps) static void virQEMUCapsInitProcessCaps(virQEMUCapsPtr qemuCaps) { - /* 'intel-iommu' shows up as a device since 2.2.0, but can - * not be used with -device until 2.7.0. Before that it - * requires -machine iommu=3Don. So we must clear the device - * capability we detected on older QEMUs - */ - if (qemuCaps->version < 2007000 && - virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_INTEL_IOMMU)) { - virQEMUCapsClear(qemuCaps, QEMU_CAPS_DEVICE_INTEL_IOMMU); - virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_IOMMU); - } - - /* Prealloc on NVDIMMs is broken on older QEMUs leading to - * user data corruption. If we are dealing with such version - * of QEMU pretend we don't know how to NVDIMM. */ - if (qemuCaps->version < 2009000) - virQEMUCapsClear(qemuCaps, QEMU_CAPS_DEVICE_NVDIMM); - if (ARCH_IS_X86(qemuCaps->arch) && virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION)) { virQEMUCapsSet(qemuCaps, QEMU_CAPS_CPU_CACHE); --=20 2.30.2