From nobody Mon Feb 9 09:54:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1645026097; cv=none; d=zohomail.com; s=zohoarc; b=ktIDc3ANLrt+Ia27fJl11bDeRqWcFOlqpaXX9jaGAwhJKQTbKIMEWH8Y4LKs0dJPzxJuFGEHJHRAWmA94yIfLNkxw/gsFnbQupLKEYDV4h3D3nwxHp0auhyBbnczauh1TeB/qvosmg1enTOoPgF7A8FvgSO/gzU9pDsPgu7GUrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645026097; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KzC49NQmEZz40raNTuUWAceqliZmyW5naGepDEtREM8=; b=VjEwUz0KPVsSCr1rh051fiWfv1qfeU/9+BI3NvcMe1GXIZ2gZ8Mgsr15pU3ccpRaqiTzxIYg42nhvzbTE27XJybUwccCKYm2kHx0h4Bfwzvk9o2uy8TCGUoeT+1GerZ5lpUY/KQbMW2OmCUnQsCFhLSIicdmY1qXmJuW137gBjg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1645026097331461.412318260637; Wed, 16 Feb 2022 07:41:37 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-150-sZ6fZYSkP7S3y_1uqEcXCg-1; Wed, 16 Feb 2022 10:41:32 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0050F1853022; Wed, 16 Feb 2022 15:41:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C16C874E94; Wed, 16 Feb 2022 15:41:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CD8214A708; Wed, 16 Feb 2022 15:41:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21GFfP67021148 for ; Wed, 16 Feb 2022 10:41:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id D98C274E98; Wed, 16 Feb 2022 15:41:25 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43A3C74E97 for ; Wed, 16 Feb 2022 15:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645026096; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KzC49NQmEZz40raNTuUWAceqliZmyW5naGepDEtREM8=; b=fh4LWZUCkeGE0rrNmTXbjRuaA8KTk6F1gwCg3pR6vGR2PZaaQ/wtB7VNVzuBJTj8u56zXu W+n/IUDYHfg9dmFL1PeA9VnlGK0eeyEPAloGwhdms0vYc+IrJHHfStHOx10XbTS68TVqT5 YyOeu1BsTLRKF4CkTvz5jnksXfDX9Yo= X-MC-Unique: sZ6fZYSkP7S3y_1uqEcXCg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 4/8] virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE_(CLOSE|EVENT)_CALLBACK Date: Wed, 16 Feb 2022 16:41:08 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1645026099079100001 Content-Type: text/plain; charset="utf-8" They are features of the RPC; drivers must say that it's not supported. Signed-off-by: Peter Krempa --- src/driver.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/driver.c b/src/driver.c index 6bebfeba58..9852a1cb17 100644 --- a/src/driver.c +++ b/src/driver.c @@ -345,6 +345,11 @@ virDriverFeatureIsGlobal(virDrvFeature feat, /* keepalive is handled at RPC level, driver implementations must alwa= ys * return 0, to signal that direct/embedded use doesn't use keepalive = */ case VIR_DRV_FEATURE_PROGRAM_KEEPALIVE: + /* Support for close callbacks and remote event filtering are both fea= tures + * of the RPC protocol and thus normal drivers must not signal support + * for them. */ + case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: + case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: *supported =3D 0; return true; @@ -360,8 +365,6 @@ virDriverFeatureIsGlobal(virDrvFeature feat, case VIR_DRV_FEATURE_MIGRATION_PARAMS: case VIR_DRV_FEATURE_MIGRATION_DIRECT: case VIR_DRV_FEATURE_MIGRATION_V1: - case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: - case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: default: return false; } --=20 2.35.1