From nobody Sun Feb 8 22:07:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1644491656; cv=none; d=zohomail.com; s=zohoarc; b=nZb4vswGy4GLwoWkZF3+h0ADEuYLdxqcy0cDvehDOlkBJkiOSYFRlXl6mqXQzcH2HYTnFsp9dyWzGbbH0fZk2ItDN7/J+20zRvV8VTC+yNzCOujxnsIBzFmdYNbc6utFW9v5YwkeHaqSX4Uky8uLkZwIgGi4fjkU93BOEm5vtfM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644491656; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OzdcrL+1VwUBADLvjlU2TBZxVFtDxNZ/udyoZeJWWoY=; b=RnHOLL4EXfmmVUxe15TS3zGy6kQuNOhLC3qxDF/RJolpSfWHcnET9FV3Ms7lB9GOa3kgRTuDMy6am25avre38Bly1ZP7s1b2UwJgkyeZ48j1QAgAhippBAFXYWlO5/4A9T4JYbG0S/HHUHK0LS4LzXvlf5nqkvPGcCL2iaq5eN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1644491656076685.6992787252063; Thu, 10 Feb 2022 03:14:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-360-EgGMga5VOsq6ym5zzsh5-Q-1; Thu, 10 Feb 2022 06:14:11 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0689344E2; Thu, 10 Feb 2022 11:14:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5413410589DA; Thu, 10 Feb 2022 11:14:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 249131802E34; Thu, 10 Feb 2022 11:14:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21ABDjfA018760 for ; Thu, 10 Feb 2022 06:13:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id D949110589DD; Thu, 10 Feb 2022 11:13:45 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6487D10589DA for ; Thu, 10 Feb 2022 11:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644491655; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OzdcrL+1VwUBADLvjlU2TBZxVFtDxNZ/udyoZeJWWoY=; b=LdjdLnWu/c2aahQ/NEzyYF1Go4548KK9CkYH2raj9yg5g3yivDNGpKVJ5FOoNFkMljMnro GAOjlaSmDUKXKWBdi+xRHpQpG1M+djtrLUU9M1kYcYUlzIot4pV6a4N3ewB0dnItdC7NSJ SZFtU6YAQ2UVfqP5IwcGavuJecbfs18= X-MC-Unique: EgGMga5VOsq6ym5zzsh5-Q-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/5] qemu_process: Accept VIR_QEMU_PROCESS_START_RESET_NVRAM flag when starting a domain Date: Thu, 10 Feb 2022 12:13:22 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1644491658497100002 Content-Type: text/plain; charset="utf-8" In one of my previous commits I've fixed the value of VIR_QEMU_PROCESS_START_RESET_NVRAM flag (which was masking another value). But what I forgot to do is update virCheckFlags() calls in two places where the flag is passed: qemuProcessLaunch() and qemuProcessStart(). Fixes: 1b636593c76f443169ef7bdb3644fd670379d04e Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_process.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 24873f6fb7..8fccf6b760 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7380,7 +7380,8 @@ qemuProcessLaunch(virConnectPtr conn, VIR_QEMU_PROCESS_START_PAUSED | VIR_QEMU_PROCESS_START_AUTODESTROY | VIR_QEMU_PROCESS_START_NEW | - VIR_QEMU_PROCESS_START_GEN_VMID, -1); + VIR_QEMU_PROCESS_START_GEN_VMID | + VIR_QEMU_PROCESS_START_RESET_NVRAM, -1); =20 cfg =3D virQEMUDriverGetConfig(driver); =20 @@ -7807,7 +7808,8 @@ qemuProcessStart(virConnectPtr conn, virCheckFlagsGoto(VIR_QEMU_PROCESS_START_COLD | VIR_QEMU_PROCESS_START_PAUSED | VIR_QEMU_PROCESS_START_AUTODESTROY | - VIR_QEMU_PROCESS_START_GEN_VMID, cleanup); + VIR_QEMU_PROCESS_START_GEN_VMID | + VIR_QEMU_PROCESS_START_RESET_NVRAM, cleanup); =20 if (!migrateFrom && !snapshot) flags |=3D VIR_QEMU_PROCESS_START_NEW; --=20 2.34.1