From nobody Fri Apr 19 07:35:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568115518; cv=none; d=zoho.com; s=zohoarc; b=nHNE4cfxk6v9SNPwlssVSXQOCWluzhXogJYfZbhCSF1zy6sAKs0WJXYshKnQgq4NHTRUit6Voa0+myJ4oR0g6osnDKqloMXj/z+LqSfsFAVAiOHcLVD7uDqGDRoOaWsNJfHsQBGVjGghEnh60Wg1KXV6cgpbsj3QN0+g4wxndoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568115518; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=qHbh+6O7eGlqW7sKC0hMGCDak+0xIS4/URhzZu7sv80=; b=RB3UCZ9Mc8uC6CX6wwWR5oPU5flpb3HZjewSy/nqOD8mMB4Njzg9AzPriCMAzXyfFAHcsV4QFPan6jvsRCrc3kTXwdCl0jW3LGPU8/SpWJfb3aGyDtdH6nxLQu1U/l1rYPnF/yXmFVVFcWcGz3ZyjQnHuj8PIaH1ziaaUFY6eL4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568115518788954.2990576234179; Tue, 10 Sep 2019 04:38:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F372F10C0947; Tue, 10 Sep 2019 11:38:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93A7F5D6B2; Tue, 10 Sep 2019 11:38:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8B5C3180B536; Tue, 10 Sep 2019 11:38:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8ABcRUg030690 for ; Tue, 10 Sep 2019 07:38:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id 550976012A; Tue, 10 Sep 2019 11:38:27 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2A56601AC for ; Tue, 10 Sep 2019 11:38:24 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 10 Sep 2019 13:38:22 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virnetdevmacvlan: Provide stubs for macvlan related functions X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Tue, 10 Sep 2019 11:38:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" In recent commit of 3d21ff72e0e the virNetDevMacVLanTapOpen() and virNetDevMacVLanTapSetup() functions were exported in our private symbols. But these functions live in an #ifdef so they need a stub implementation. Then in 1b46566ee the virNetDevMacVLanIsMacvtap() function was implemented but again, only for #idef and without stub. Signed-off-by: Michal Privoznik --- Pushed under build breaker and trivial rules. src/util/virnetdevmacvlan.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index 9a9750f24a..e8a9b052b6 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -1178,6 +1178,13 @@ int virNetDevMacVLanRestartWithVPortProfile(const ch= ar *cr_ifname, } =20 #else /* ! WITH_MACVTAP */ +bool virNetDevMacVLanIsMacvtap(const char *ifname ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Cannot create macvlan devices on this platform= ")); + return false; +} + int virNetDevMacVLanCreate(const char *ifname ATTRIBUTE_UNUSED, const char *type ATTRIBUTE_UNUSED, const virMacAddr *macaddress ATTRIBUTE_UNUSED, @@ -1197,6 +1204,26 @@ int virNetDevMacVLanDelete(const char *ifname ATTRIB= UTE_UNUSED) return -1; } =20 +int +virNetDevMacVLanTapOpen(const char *ifname ATTRIBUTE_UNUSED, + int *tapfd ATTRIBUTE_UNUSED, + size_t tapfdSize ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Cannot create macvlan devices on this platform= ")); + return -1; +} + +int +virNetDevMacVLanTapSetup(int *tapfd ATTRIBUTE_UNUSED, + size_t tapfdSize ATTRIBUTE_UNUSED, + bool vnet_hdr ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Cannot create macvlan devices on this platform= ")); + return -1; +} + int virNetDevMacVLanCreateWithVPortProfile(const char *ifname ATTRIBUTE_UN= USED, const virMacAddr *macaddress AT= TRIBUTE_UNUSED, const char *linkdev ATTRIBUTE_U= NUSED, --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list