From nobody Sun May 5 19:29:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561133814; cv=none; d=zoho.com; s=zohoarc; b=Y2VSHXYWHgVCcw5TjyelIlHyA/jmgmGnKmwMoG2bUsCNb0kybltKrYAFL4hO8yxtho0dzjea9uJRkrvPFXuB+suUpL4X3RqXu77M8Jo366SpWxaBam97X0gHvcbV0d0OTdXCSoXL+7ofQD5ZA/IWr5gnOW0a4dCz3/6FTyvOT4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561133814; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=O8kqxJupdLHrIIpORJqrPCb5vqIiOErpMwfB3yx3Zac=; b=cRXdeBaT9losASLUFrIePhlb33gg2WL6VeYusz2L3WB5dVatYr6acIqq2NDz8/lanYzOY/p3th0F5WPFNPQZ6DgsLU12pd08rNTXpdfVL10Zmz1TEJk7vGk9XjLbzmjdpxc0jVCAvH7ruXXSctH7QBQr/v5LCxCArvjaQClUwII= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561133814131526.2490184129337; Fri, 21 Jun 2019 09:16:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68C373082B67; Fri, 21 Jun 2019 16:16:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 240FC5B683; Fri, 21 Jun 2019 16:16:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA6D01806B1C; Fri, 21 Jun 2019 16:16:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5LGC3Fx017710 for ; Fri, 21 Jun 2019 12:12:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id E27F719C6A; Fri, 21 Jun 2019 16:12:03 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E88B19C4F for ; Fri, 21 Jun 2019 16:12:01 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 21 Jun 2019 18:11:59 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virStorageSourceChainHasManagedPR: Check propely X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 21 Jun 2019 16:16:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" In the virStorageSourceChainHasManagedPR() function we iterate over whole backing chain trying to determine if one of the layers has managed PR configured. But due to a typo we in fact check the top layer only. Signed-off-by: Michal Privoznik --- Pushed under trivial rule. src/util/virstoragefile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 2b1c0a5b8e..f7495ab6da 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2083,7 +2083,7 @@ virStorageSourceChainHasManagedPR(virStorageSourcePtr= src) virStorageSourcePtr n; =20 for (n =3D src; virStorageSourceIsBacking(n); n =3D n->backingStore) { - if (virStoragePRDefIsManaged(src->pr)) + if (virStoragePRDefIsManaged(n->pr)) return true; } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list