From nobody Sat Feb 7 09:29:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674466479; cv=none; d=zohomail.com; s=zohoarc; b=YzCPwrSOSTnlOWU1wj8hCKUd1D0hUgH2Ieh6VRmpqwhtZTX9dQZu/enZTlG74sGBXdvetsxFe0R55rIpi3eVdeRY7R5VtBNnVEMwFEzZC3RtcJqaPcJ6g6zq8m0pxgagsxuEmhq6jqUxlg/B3yyVhfXIL2qRIhxt99YLyH/a4ow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674466479; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gz1FdgTE000zrHJ35NVwaFuDpT5htFdDYunvUQsFLFA=; b=fvCUrpViwKuTFyfE2C9nASqvLpwNl4N3XVCmeRGxjAPxbZ9+Q8yZgis7KAaeiGmFPUTAKJ5o2BZpTUA3qNt3o07Ol5oDPCLIB5oR8z/i4qHAq/vRGEkhBjGpp9vwpofq2d+Fqi5/KRPuaMxTem2JMvAKzzh+GFm5lF8Zod15eVg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1674466479777812.1899900482962; Mon, 23 Jan 2023 01:34:39 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-cuWEj7QXPgOvS2QN21NCsw-1; Mon, 23 Jan 2023 04:34:33 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D6DF31871DA0; Mon, 23 Jan 2023 09:34:29 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0F3D4085720; Mon, 23 Jan 2023 09:34:29 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A422619465B3; Mon, 23 Jan 2023 09:34:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C0AC9194658C for ; Mon, 23 Jan 2023 09:34:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A54451121339; Mon, 23 Jan 2023 09:34:27 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C0CD1121333 for ; Mon, 23 Jan 2023 09:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674466478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=gz1FdgTE000zrHJ35NVwaFuDpT5htFdDYunvUQsFLFA=; b=g9BC1D3IqHjOkJO8A2EXu11Pie3saSHBv8roKx8Gr6GgXFiJu1NXG8XlhvhVaXOtS+xBQq bvmwwE0Jt+KmQ0I31Lqpjnklp9wkiHjtxPubytWNinUDT5ZWxjr1Smymi0u+mB1IDPg+zv Z+hDNSbAwNcXgijWrsjP2I3Bw44QpbQ= X-MC-Unique: cuWEj7QXPgOvS2QN21NCsw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 03/15] vbox: Drop @iid from UIMachine::LaunchVMProcess() Date: Mon, 23 Jan 2023 10:34:12 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674466481317100009 Content-Type: text/plain; charset="utf-8"; x-default="true" The @iid argument of UIMachine::LaunchVMProcess() callback is unused. Drop it and also its propagation from parent functions. Signed-off-by: Michal Privoznik --- src/vbox/vbox_common.c | 6 +++--- src/vbox/vbox_tmpl.c | 1 - src/vbox/vbox_uniformed_api.h | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index ea3a54b7c9..7b1b8bb1b0 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -2046,7 +2046,7 @@ static int vboxDomainUndefine(virDomainPtr dom) } =20 static int -vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine, vboxII= D *iid) +vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine) { struct _vboxDriver *data =3D dom->conn->privateData; int vrdpPresent =3D 0; @@ -2147,7 +2147,7 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMac= hine *machine, vboxIID *iid if (vrdpPresent) VBOX_UTF8_TO_UTF16("vrdp", &sessionType); =20 - rc =3D gVBoxAPI.UIMachine.LaunchVMProcess(data, machine, iid, + rc =3D gVBoxAPI.UIMachine.LaunchVMProcess(data, machine, sessionType, env, &progress); =20 @@ -2238,7 +2238,7 @@ static int vboxDomainCreateWithFlags(virDomainPtr dom= , unsigned int flags) gVBoxAPI.UIMachine.GetState(machine, &state); =20 if (gVBoxAPI.machineStateChecker.NotStart(state)) { - ret =3D vboxStartMachine(dom, i, machine, &iid); + ret =3D vboxStartMachine(dom, i, machine); } else { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("machine is not in " diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 967e44fea4..57d581e49c 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -746,7 +746,6 @@ _machineRemoveSharedFolder(IMachine *machine, PRUnichar= *name) static nsresult _machineLaunchVMProcess(struct _vboxDriver *data, IMachine *machine, - vboxIID *iid G_GNUC_UNUSED, PRUnichar *sessionType, PRUnichar *env, IProgress **progress) { diff --git a/src/vbox/vbox_uniformed_api.h b/src/vbox/vbox_uniformed_api.h index 18f352d98e..393e48827f 100644 --- a/src/vbox/vbox_uniformed_api.h +++ b/src/vbox/vbox_uniformed_api.h @@ -182,7 +182,6 @@ typedef struct { PRBool automount); nsresult (*RemoveSharedFolder)(IMachine *machine, PRUnichar *name); nsresult (*LaunchVMProcess)(struct _vboxDriver *driver, IMachine *mach= ine, - vboxIID *iid, PRUnichar *sessionType, PRUnichar *env, IProgress **progress); nsresult (*Unregister)(IMachine *machine, PRUint32 cleanupMode, --=20 2.39.1