From nobody Mon Sep 14 04:56:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1787839289; cv=none; d=zohomail.com; s=zohoarc; b=HLoDhzeguI3+G+0uR9LxHcLVpu3dN43sLgOldIwleOMateAcCTEbi6muAJiMnopbVHaGduVl0CAVYM8pAyRMYcVl061zclXBGxv9JQYwm7DkGz0vJkssZBYfviEAtUyVwN2S8kxFWiveqpq60QiPP9Fg58GCoxX+rWavEvuD54Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787839289; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=iMqAQBsEzzVAo/NIbWw9s9qPMEQ25QOhV2stBDhAFFE=; b=SYNHt3MOPFlxl2PhRhvnZqFgsfOfRYPOb5Klk8iBd8kNd2u9BInmCxKYrZ5zJ3/+7A8Ts+xEokZFvJjAWIFp2buExlpXUEBszvWYmO/SyeXzLiRLvmrLGd5V88lN+rgjUzu8UMVTMQnLkL1OG3+HEB6iQyEkvT4JjIzPBTnUFs4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1787839289855766.552075881708; Thu, 27 Aug 2026 07:01:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 95765419FD; Thu, 27 Aug 2026 10:01:28 -0400 (EDT) Received: from [172.19.199.13] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id B3F754191D for ; Thu, 27 Aug 2026 10:00:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9E6793FAE9; Thu, 27 Aug 2026 10:00:23 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6E1EA3F97D for ; Thu, 27 Aug 2026 10:00:22 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-z26flAtcMxaT6HnVB8w9eg-1; Thu, 27 Aug 2026 10:00:20 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 601C71835AD9 for ; Thu, 27 Aug 2026 14:00:19 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.49.31]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1C2E21800609 for ; Thu, 27 Aug 2026 14:00:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787839222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iMqAQBsEzzVAo/NIbWw9s9qPMEQ25QOhV2stBDhAFFE=; b=RFnwOpvc7GPvdWSXuAHR5T9iSpJ+pVybQyiG6i57FG00keF0tVfsUr5+13iZUn+klioa8a qc1SBBI1RaRz7rnVUU+KN9oGUS32fWv+VgMNq92HvsmJ+Izcsisq5DV7WEjW9NsoQ63+Tz CqsWfM/+WnWcgXzlFLiqQkcBX+xJOT0= X-MC-Unique: z26flAtcMxaT6HnVB8w9eg-1 X-Mimecast-MFC-AGG-ID: z26flAtcMxaT6HnVB8w9eg_1787839219 To: devel@lists.libvirt.org Subject: [libvirt PATCH v2] storage: logical: don't write past buffer bounds Date: Thu, 27 Aug 2026 15:59:24 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cIeb8PA01Tjdr99fQro9eYTX6BXxqma8hVk4dSNXbuw_1787839219 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AW7SRDYBEVGTJORCR5I7MZHIQO6F5VZ7 X-Message-ID-Hash: AW7SRDYBEVGTJORCR5I7MZHIQO6F5VZ7 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1787839291639158500 From: J=C3=A1n Tomko If parsed number of extents is 0, the calculated buffer size won't hold the first regex_unit. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/913 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/storage/storage_backend_logical.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_ba= ckend_logical.c index 51e9337820..6138c6fb81 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -127,6 +127,7 @@ virStorageBackendLogicalParseVolExtents(virStorageVolDe= f *vol, unsigned long long offset; unsigned long long size; unsigned long long length; + g_auto(GStrv) regex_array =3D NULL; g_autofree char *regex =3D NULL; =20 /* Assume 1 extent (the regex for 'devices' is "(\\S+)") and only @@ -160,13 +161,10 @@ virStorageBackendLogicalParseVolExtents(virStorageVol= Def *vol, } =20 /* Allocate space for 'nextents' regex_unit strings plus a comma for e= ach */ - regex =3D g_new0(char, nextents * (strlen(regex_unit) + 1) + 1); - strcat(regex, regex_unit); - for (i =3D 1; i < nextents; i++) { - /* "," is the separator of "devices" field */ - strcat(regex, ","); - strcat(regex, regex_unit); - } + regex_array =3D g_new0(char *, nextents + 1); + for (i =3D 0; i < nextents; i++) + regex_array[i] =3D g_strdup(regex_unit); + regex =3D g_strjoinv(",", regex_array); =20 re =3D g_regex_new(regex, 0, 0, &err); if (!re) { --=20 2.55.0