From nobody Sun Feb 8 16:05:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661443195; cv=none; d=zohomail.com; s=zohoarc; b=SwpdJivTzygoPnP2lo1MXmDRMAHB1Y/ZIciJ00KMM+PQEf1/2s4IEhN7NXypPNg7Ezn07vuJRv67VepKMFuzJF1hnEa81lhXFkJdaolkZxkCEoq4ByCRh1kdkmDvxWVrvEtw6fBNyCvWToelKvNLHfjI5mBczJ1Wq57S1pMps5Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661443195; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xTQFVhwt30pVj66uHknY0JeqM1+OOHfZ14f8MLwm9ss=; b=Tgo0PqPaOA36kVj8pZxuH4g3OuCw/ndlx8iJCVKS30AprirZUVZNYEkt8rtj5cqxuDfeEEq/jNHFyM9GMSGSgvKWUShC0qizHERNp6Wjja6orLH5opX8YxU0pUYsvAxoxB+u0wOmLfIEvzaex3x+isTDcKlRKmJ5QCto14fqG7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661443195746673.9670307626421; Thu, 25 Aug 2022 08:59:55 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-445-3EAX6kLeM5WzjHPcvHs2og-1; Thu, 25 Aug 2022 11:59:48 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2021E80231E; Thu, 25 Aug 2022 15:59:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09A3740E7F2C; Thu, 25 Aug 2022 15:59:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B34551946A62; Thu, 25 Aug 2022 15:59:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8BA9B1946A72 for ; Thu, 25 Aug 2022 15:59:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6F02E4010D2A; Thu, 25 Aug 2022 15:59:39 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1950E40C141D for ; Thu, 25 Aug 2022 15:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661443194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xTQFVhwt30pVj66uHknY0JeqM1+OOHfZ14f8MLwm9ss=; b=eih3602euGWY6oQPpSI9x+Txu6wyORYYfg8PTF3Hji7Gr01lcst/Yg2wNGxn6C1VTBUnKU RnMbKg1/VBu9DL2+tw9Uz8KbMlxfhm1jXlSSqMLaIUPyQjf0XnNuozbciN0aPDPZUVkrBU G03hF88mb/GxDYz7C/OZiMOQAy3xDuk= X-MC-Unique: 3EAX6kLeM5WzjHPcvHs2og-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 03/12] qemu: assume QEMU_CAPS_CHARDEV_LOGFILE Date: Thu, 25 Aug 2022 17:59:26 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661443197465100003 Introduced in QEMU 2.6 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/qemu/qemu_validate.c | 8 -------- tests/qemuxml2argvtest.c | 4 +--- tests/qemuxml2xmltest.c | 1 - 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 245b953c86..bf7228e3ea 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2227,14 +2227,6 @@ qemuValidateDomainChrSourceDef(const virDomainChrSou= rceDef *def, break; } =20 - if (def->logfile) { - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_LOGFILE)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("logfile not supported in this QEMU binary")); - return -1; - } - } - return 0; } =20 diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index bedd190cb1..51434ab857 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1579,8 +1579,7 @@ mymain(void) QEMU_CAPS_DEVICE_VFIO_PCI); =20 DO_TEST("serial-file-log", - QEMU_CAPS_DEVICE_ISA_SERIAL, - QEMU_CAPS_CHARDEV_LOGFILE); + QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST("serial-spiceport", QEMU_CAPS_DEVICE_QXL, QEMU_CAPS_SPICE, @@ -2827,7 +2826,6 @@ mymain(void) QEMU_CAPS_KVM); DO_TEST("aarch64-pci-serial", QEMU_CAPS_DEVICE_PCI_SERIAL, - QEMU_CAPS_CHARDEV_LOGFILE, QEMU_CAPS_OBJECT_GPEX, QEMU_CAPS_DEVICE_PCI_BRIDGE, QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE, diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 0507b70825..85a57be87a 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -991,7 +991,6 @@ mymain(void) QEMU_CAPS_DEVICE_VIRTIO_GPU); DO_TEST("aarch64-pci-serial", QEMU_CAPS_DEVICE_PCI_SERIAL, - QEMU_CAPS_CHARDEV_LOGFILE, QEMU_CAPS_OBJECT_GPEX, QEMU_CAPS_DEVICE_PCI_BRIDGE, QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE, --=20 2.37.1