From nobody Tue Mar 3 04:55:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771245249; cv=none; d=zohomail.com; s=zohoarc; b=TaZXrl3Ya5sQYGP27uDgOfWm6187uMrjtICiCfUqi7/08u9IxSSAhbCNTFZpOGe54Q6mDO+yb2SmD9mexLgeSowAe53hnSPsmPOqG6sg0CcfbwMspG7BI9FbuCZuRIxL5+HlA7ofzj/SxrmMYcJYMZgPu6RzEdA6R/mFDYcSi84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771245249; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=+/7+U76q72IuptgbXv+4vSO3pGJ7VzFWHEZlP4LzAuU=; b=cuBPcee2GQsDS/cUC58+1Tnt39Ur3RW63rZ04xm63W8lAvBZp8XUw/Vgsyx8y/IBLetLeb1tnw9JIgpwqnkYUlG7f+8Wj1F5UJnyJZ0rH/nDb8gC1depAT6zLuUgyUMhVYdxH51bmFTmKYUE0IIpA8OpxS6tL9Igbvm035mfuf0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177124524958918.82356985138142; Mon, 16 Feb 2026 04:34:09 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9BB5041902; Mon, 16 Feb 2026 07:34:08 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 581F1419D0; Mon, 16 Feb 2026 07:28:38 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id CB8EA3F880; Mon, 16 Feb 2026 07:28:25 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3F7CD3F343 for ; Mon, 16 Feb 2026 07:28:25 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-PEnh30qJNZGrFvljlRy23Q-1; Mon, 16 Feb 2026 07:28:23 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCC06180047F for ; Mon, 16 Feb 2026 12:28:22 +0000 (UTC) Received: from antique-laptop.rosnicka.net (unknown [10.45.242.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32F4530001BE for ; Mon, 16 Feb 2026 12:28:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771244904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+/7+U76q72IuptgbXv+4vSO3pGJ7VzFWHEZlP4LzAuU=; b=RrMAH1p+JJFla58t8ub12mqlfYfpHovG9zatqTLy6+JNsq40NM2HgZBNhF/bdq8S0l1NS4 qmKkh51DNg8o0HZzvRjx1ocmI4/NezEfoJILd/2sOoa/BDq1V2qrL3X4R6xeHEnY7mRyfA CfBtQKJXFkGzMCQ5T8Q5bDsOK5FhMPw= X-MC-Unique: PEnh30qJNZGrFvljlRy23Q-1 X-Mimecast-MFC-AGG-ID: PEnh30qJNZGrFvljlRy23Q_1771244903 To: devel@lists.libvirt.org Subject: [libvirt PATCH 04/24] qemu_process: Refactor qemuProcessOpenIommuFd Date: Mon, 16 Feb 2026 13:27:56 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AgBo0w8rU_GBy1DVPKaRUJeNN28lAhEAfBS4c_vlNuQ_1771244903 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WKGBMSHJRYSDUVKTZ772TN4DHITC4GVT X-Message-ID-Hash: WKGBMSHJRYSDUVKTZ772TN4DHITC4GVT X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771245250566158500 Content-Type: text/plain; charset="utf-8"; x-default="true" This will allow us reusing same code for hotplug. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9b459f47ca..d21abb9eb6 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7680,24 +7680,23 @@ qemuProcessPrepareHostBackendChardevHotplug(virDoma= inObj *vm, /** * qemuProcessOpenIommuFd: * @vm: domain object - * @iommuFd: returned file descriptor * * Opens /dev/iommu file descriptor for the VM. * - * Returns: FD on success, -1 on failure + * Returns: 0 on success, -1 on failure */ static int qemuProcessOpenIommuFd(virDomainObj *vm) { - int fd =3D -1; + qemuDomainObjPrivate *priv =3D vm->privateData; =20 VIR_DEBUG("Opening IOMMU FD for domain %s", vm->def->name); =20 - if ((fd =3D virIOMMUFDOpenDevice()) < 0) + if ((priv->iommufd =3D virIOMMUFDOpenDevice()) < 0) return -1; =20 - VIR_DEBUG("Opened IOMMU FD %d for domain %s", fd, vm->def->name); - return fd; + VIR_DEBUG("Opened IOMMU FD %d for domain %s", priv->iommufd, vm->def->= name); + return 0; } =20 /** @@ -7754,7 +7753,6 @@ qemuProcessOpenVfioDeviceFd(virDomainHostdevDef *host= dev) static int qemuProcessOpenVfioFds(virDomainObj *vm) { - qemuDomainObjPrivate *priv =3D vm->privateData; size_t i; =20 /* Check if we have any hostdevs that need VFIO FDs */ @@ -7772,8 +7770,7 @@ qemuProcessOpenVfioFds(virDomainObj *vm) return -1; =20 /* Open IOMMU FD */ - priv->iommufd =3D qemuProcessOpenIommuFd(vm); - if (priv->iommufd =3D=3D -1) + if (qemuProcessOpenIommuFd(vm) < 0) return -1; } } --=20 2.53.0