From nobody Mon Feb 9 00:26:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594894573; cv=none; d=zohomail.com; s=zohoarc; b=dauiKOuZedPr7vVA8w3qsIN0WVEeJ/edbtNZ6CSwegS0/22fk9X0qyf7BeZkrRMzEmHrSSwNG2iKQiOiopcGZtLlDNFgml/9opQBT+LYwpMNOIt3PP4+8zeBYEWABzWpzactF/PVUOr2mc1rDqfr8GXVEtvMnDFSR8daSXjzIXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594894573; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Erg2opM+5YSmomy9dirGHWkqXUKdcFKnZX3G73+h0lU=; b=R+gMm80wHCd87PnvLfw/ckUuGxMa3swlE3N3WQfk+INmtD1lLMjUyZd4HgcIKCv5LyIiUM+YmXr9bKjNXgMKsLrKVFsaRvoj9D0pO6LnAxJxmG0t59jcdTl2cmXHE6w0EPWonjPSHXM4CenZOKbqgCVzXonjTIDN3KACuc7TwF0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1594894573592250.7200481632649; Thu, 16 Jul 2020 03:16:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-W_CV5DxLNnaXZ6ivqc5P_w-1; Thu, 16 Jul 2020 06:13:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 161C880BCC2; Thu, 16 Jul 2020 10:13:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAE9372AE7; Thu, 16 Jul 2020 10:13:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B84CE730EF; Thu, 16 Jul 2020 10:13:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 06GA6EDG019442 for ; Thu, 16 Jul 2020 06:06:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5AA8A2DE69; Thu, 16 Jul 2020 10:06:14 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.194.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA1412B6DB for ; Thu, 16 Jul 2020 10:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594894572; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Erg2opM+5YSmomy9dirGHWkqXUKdcFKnZX3G73+h0lU=; b=LePz4/k6CfJJSd80H7EGOoKG0MLX8oAFZEIu4dDymHp5kwu0IRqmhCj0xdZE9dCQ5HQHX2 X7mMYBOc1AsNiRtikHyyY6ExR4yXEJSId8j5g44akME3Fpg3ryYJuch5pt1ai/oPLQSEEi p+tomTfxYo//C4bwIGzz3lIK8nLhLcc= X-MC-Unique: W_CV5DxLNnaXZ6ivqc5P_w-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 256/351] meson: tools: build virt-login-shell binary Date: Thu, 16 Jul 2020 11:58:12 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- tools/Makefile.am | 9 --------- tools/meson.build | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index d285146622f..50acdeab22e 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -41,7 +41,6 @@ endif WITH_SANLOCK =20 if WITH_LOGIN_SHELL conf_DATA +=3D virt-login-shell.conf -bin_PROGRAMS +=3D virt-login-shell libexec_PROGRAMS =3D virt-login-shell-helper endif WITH_LOGIN_SHELL =20 @@ -62,14 +61,6 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile =20 noinst_LTLIBRARIES =3D =20 -# virt-login-shell will be setuid, and must not link to anything -# except glibc. It wil scrub the environment and then invoke the -# real virt-login-shell-helper binary. -virt_login_shell_SOURCES =3D \ - virt-login-shell.c - -virt_login_shell_CPPFLAGS =3D $(STANDALONE_CPPFLAGS) - virt_login_shell_helper_SOURCES =3D \ virt-login-shell-helper.c =20 diff --git a/tools/meson.build b/tools/meson.build index 8c7d3ec64ab..59c5f3c56ff 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -74,3 +74,20 @@ if conf.has('WITH_HOST_VALIDATE') install_rpath: libdir, ) endif + +if conf.has('WITH_LOGIN_SHELL') + # virt-login-shell will be setuid, and must not link to anything + # except glibc. It wil scrub the environment and then invoke the + # real virt-login-shell-helper binary. + executable( + 'virt-login-shell', + [ + 'virt-login-shell.c', + ], + include_directories: [ + top_inc_dir, + ], + install: true, + install_dir: bindir, + ) +endif --=20 2.26.2