From nobody Sun Feb 8 11:21:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601920145; cv=none; d=zohomail.com; s=zohoarc; b=IjAnA1t8LEP/m2kmorRy+TE7AwVZSsD7fxGKytgfvRcn+J37A1DT4JwSF7/+J+uy9HogB2FluwwaY2KQThN17DNrZa2/bGBUJZ1oZ2Zq/B+Mr87sHRb8dk7MWEw+cO9G8iDhtcSqHRQf52K0OeLp96pvPmKcHFRP/UDyZctemZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601920145; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=br5IwSvBaDXtSmyQomc+e42Lyp+Whu/seiNCgEVXgI8=; b=f4f0mMy3clSjO7g4QYh7IMb5Pym8hUQ8YfyaofhHA87MRpeDtz+VkVZrR58tEMb+b/Nf1CNN8Pe3G7vTY16f7fjGODToITwgZcP1XvTsA++lGp1nc7abfqVvjXMk3hC0roHs8MkKr2HWdLllENsy9oyK96e1r7CwvnfDPNWHvoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601920145367671.4976123345176; Mon, 5 Oct 2020 10:49:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-bw2U27hSNhukeX_VffwNKA-1; Mon, 05 Oct 2020 13:49:00 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC34F18C89CB; Mon, 5 Oct 2020 17:48:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD44778800; Mon, 5 Oct 2020 17:48:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8620F44A71; Mon, 5 Oct 2020 17:48:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 095HmeJt015640 for ; Mon, 5 Oct 2020 13:48:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 44A235C225; Mon, 5 Oct 2020 17:48:40 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0E6C5C1C4 for ; Mon, 5 Oct 2020 17:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601920144; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=br5IwSvBaDXtSmyQomc+e42Lyp+Whu/seiNCgEVXgI8=; b=ElZNbV0F7rfR4pix4NMgCym85yIuxOITtdClQtPBcVepJPEzLxyX9dCLDyqoxxoNbYF8N9 Leu8j8+bTVMksyqv2asYIHebPYP4SbqOhv7dyQ7123LDsAkZWCBgXrFMDU/G8rH5Xc0ceZ qBOvx4J2te3YExrWKArr6ru95pEG6L4= X-MC-Unique: bw2U27hSNhukeX_VffwNKA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 08/12] util: systemd: use g_new0 Date: Mon, 5 Oct 2020 19:48:23 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: J=C3=A1n Tomko --- src/util/virsystemd.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 8456085476..8373ee6509 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -364,8 +364,7 @@ int virSystemdCreateMachine(const char *name, if (g_atomic_int_get(&hasCreateWithNetwork)) { g_autoptr(virError) error =3D NULL; =20 - if (VIR_ALLOC(error) < 0) - return -1; + error =3D g_new0(virError, 1); =20 guuid =3D g_variant_new_fixed_array(G_VARIANT_TYPE("y"), uuid, 16, sizeof(unsigned char)); @@ -495,8 +494,7 @@ int virSystemdTerminateMachine(const char *name) if (!(conn =3D virGDBusGetSystemBus())) return -1; =20 - if (VIR_ALLOC(error) < 0) - return -1; + error =3D g_new0(virError, 1); =20 /* * The systemd DBus API we're invoking has the @@ -655,14 +653,8 @@ virSystemdActivationAddFD(virSystemdActivationPtr act, virSystemdActivationEntryPtr ent =3D virHashLookup(act->fds, name); =20 if (!ent) { - if (VIR_ALLOC(ent) < 0) - return -1; - - if (VIR_ALLOC_N(ent->fds, 1) < 0) { - virSystemdActivationEntryFree(ent); - return -1; - } - + ent =3D g_new0(virSystemdActivationEntry, 1); + ent->fds =3D g_new0(int, 1); ent->fds[ent->nfds++] =3D fd; =20 VIR_DEBUG("Record first FD %d with name %s", fd, name); @@ -902,8 +894,7 @@ virSystemdActivationNew(virSystemdActivationMap *map, const char *fdnames; =20 VIR_DEBUG("Activated with %d FDs", nfds); - if (VIR_ALLOC(act) < 0) - return NULL; + act =3D g_new0(virSystemdActivation, 1); =20 if (!(act->fds =3D virHashCreate(10, virSystemdActivationEntryFree))) goto error; --=20 2.26.2