From nobody Sat Feb 7 05:00:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1726646318121110.49750921064935; Wed, 18 Sep 2024 00:58:38 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E87AD1AD6; Wed, 18 Sep 2024 03:58:36 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id F14D6188A; Wed, 18 Sep 2024 03:55:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 70B5C1AC6; Wed, 18 Sep 2024 03:55:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DE2531413 for ; Wed, 18 Sep 2024 03:55:29 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-Z_HfRUI5P6OvrfYmQPKpHA-1; Wed, 18 Sep 2024 03:55:28 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3CB5D1956089 for ; Wed, 18 Sep 2024 07:55:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5E2A819560A3 for ; Wed, 18 Sep 2024 07:55:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726646129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IBkt0VVTc9jfH8GhpSZzJw3WQy5n+1U7gdrG2OYfbQk=; b=XPILEOWSe8EqacL5dvqB62aPBy2Je32LCE9AYJhJfBPO7ciM+ffnh086SEUdh6stE56fKv IkhwzYHsrfyWG4Gq6YfsSk4FdBl4z45/c3jSUX6BQ0vzW7SwZDDovMZ7sjhn8Kr2uT6q4O rG8ffwVch00jolttzC6GnqGpDZkTwIQ= X-MC-Unique: Z_HfRUI5P6OvrfYmQPKpHA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 4/8] qemuxmlconftest: Add support for validating schema for 'chardev-add' Date: Wed, 18 Sep 2024 09:55:14 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MXSRO6335UC5ZMCWIGPWSDNXHLMVHMZE X-Message-ID-Hash: MXSRO6335UC5ZMCWIGPWSDNXHLMVHMZE X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726646318962116600 Content-Type: text/plain; charset="utf-8" While qemu doesn't yet support JSON args for chardev, we can at least for test purposes of schema validation plumb it to the '-chardev' command as it's easier to create test cases via XML than to write them into code in 'qemuhotplugtest'. Additionally once this becomes available and if e.g. the syntax is fixed we'll be able to also catch the differences early. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/qemuxmlconftest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 6fc8d5eabd..914326bc3c 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -504,6 +504,7 @@ static const struct testValidateSchemaCommandData comma= nds[] =3D { { "-netdev", "netdev_add", false }, { "-object", "object-add", false }, { "-device", "device_add", true }, + { "-chardev", "chardev-add", false }, }; static int --=20 2.46.0