From nobody Mon Feb 9 02:51:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864218; cv=none; d=zohomail.com; s=zohoarc; b=OPlWFsNDZ08qWroHlWJsX4I+o2QJkUxW3cp/e83+VEoXws2/+yqPHLoWGcle/P6xld7RPZeq/4G2gFw6CMRzvy6KSXsRSzKkbFntEGi1lK68zvmYzdMd2yhKkWPFY172hXsYdvfBCGQCM2PX/weIndovTtUVtmlM63lPxqnoByQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864218; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=53gRWc3uYPmTUzoi01k2jlTbgKNNxm6HGsFf6+TPDGc=; b=koNvVRm+KNyHpOBtvIJGY5OvWxHOUcBSbFcTb0gkf//tS0FQGjn/ZVkB3/wyu7PRxqaJQ8UlY0QvqCFqj6oj9aiV2TjXbOkjWRmZkRrXQuHkrP3T0WikqFwHzM3YvqIHbRnV1MEhPrS/L+lyPd+Gd6UvO6ZIZGmrBr0tM+3p8Nc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626864218108565.5643126443323; Wed, 21 Jul 2021 03:43:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-bZCKlFrXP8mUucZYS8IsTQ-1; Wed, 21 Jul 2021 06:43:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2AF14804145; Wed, 21 Jul 2021 10:43:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F81560C59; Wed, 21 Jul 2021 10:43:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CE32F181A2A3; Wed, 21 Jul 2021 10:43:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAh3A9000906 for ; Wed, 21 Jul 2021 06:43:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id DA98D19D9B; Wed, 21 Jul 2021 10:43:03 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4167B19C79 for ; Wed, 21 Jul 2021 10:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864217; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=53gRWc3uYPmTUzoi01k2jlTbgKNNxm6HGsFf6+TPDGc=; b=A4s+LpfZs3JYIUEVmBT6Mh0dAZv+RqzqH31Z0Rg+1tgX9Hk6F9O5coEK9NisM7taOoTMQo MfCqVqCOAvo7Swcr85WaIi+/oOlpj4jMU8HuS6D7ScEaGcTCp7mFKYU36RjFuuFgEtR/NB sTwdBpAxaalXLW6zkdIHSgZs+J/yftk= X-MC-Unique: bZCKlFrXP8mUucZYS8IsTQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 13/33] qemu: Remove return value from qemuMonitorDomainJobStatusChangeCallback Date: Wed, 21 Jul 2021 12:42:25 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864219464100001 Content-Type: text/plain; charset="utf-8" Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 10 +++++----- src/qemu/qemu_process.c | 3 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index f2b784e4a6..e71cea797f 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -210,11 +210,11 @@ typedef void (*qemuMonitorDomainBlockJobCallback)(qem= uMonitor *mon, int status, const char *error, void *opaque); -typedef int (*qemuMonitorDomainJobStatusChangeCallback)(qemuMonitor *mon, - virDomainObj *vm, - const char *jobnam= e, - int status, - void *opaque); +typedef void (*qemuMonitorDomainJobStatusChangeCallback)(qemuMonitor *mon, + virDomainObj *vm, + const char *jobna= me, + int status, + void *opaque); typedef int (*qemuMonitorDomainTrayChangeCallback)(qemuMonitor *mon, virDomainObj *vm, const char *devAlias, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index abbf1776a0..cf4b0e70df 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -977,7 +977,7 @@ qemuProcessHandleBlockJob(qemuMonitor *mon G_GNUC_UNUSE= D, } -static int +static void qemuProcessHandleJobStatusChange(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, const char *jobname, @@ -1034,7 +1034,6 @@ qemuProcessHandleJobStatusChange(qemuMonitor *mon G_G= NUC_UNUSED, cleanup: qemuProcessEventFree(processEvent); virObjectUnlock(vm); - return 0; } --=20 2.31.1