From nobody Fri Nov 21 10:01:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762966548; cv=none; d=zohomail.com; s=zohoarc; b=Os9e8ssDYRrQhdGvHKmIX9iZW2aIMwmjXjh3GXalLnO9AKxz1tmXUSr2ijBZLJDKVS0guSTj+Ts3O3GFN8rU4zlSRbdEAKI2fk/7UCfhwaN8NKEP7ET3OTgU7LRZtU2GinQ2DuTm1lI00pEbcoQwhM06DcVEI/zPpFO387uUEaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762966548; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=vnUNQbQ1Ddx+rHaxHVpro+pav8sSdeAhbdbcfgdiiNc=; b=SCHd7CyyF/2F/QdouKN9gUQFLNptpSwzPlCMHKxKfd6u8sm7nxqvk814tZN3jInJPHAuigJxJTAmmaPpkua0N5E0LpEiU7F3L4cbsGRgz/ZPZntvIqNeXeBvLce9711tqg+PKH2MCM9wkTtmzwndSctma1tfFtDKDQnRWotq3M8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762966548153711.0301836087059; Wed, 12 Nov 2025 08:55:48 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 2339A44654; Wed, 12 Nov 2025 11:55:46 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 74772446C2; Wed, 12 Nov 2025 11:55:01 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id E1DF444625; Wed, 12 Nov 2025 11:54:26 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 543D544624 for ; Wed, 12 Nov 2025 11:54:25 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-kQdrm7puOF2j1nq8n6N21A-1; Wed, 12 Nov 2025 11:54:23 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 745B81801306 for ; Wed, 12 Nov 2025 16:54:22 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6325230044EC; Wed, 12 Nov 2025 16:54:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762966464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vnUNQbQ1Ddx+rHaxHVpro+pav8sSdeAhbdbcfgdiiNc=; b=N9YGLmGo5M3R8f41capdLdUlN+AoF2SwCdo0+hUYNWcWWVk5dCaXUUsdKcwslwAFC07VmM sEwrrGbA+cyHG2qgW5IDjNG34o7ElDQOjtOZ1XU3Obt8nv5UO/FGuBFXtrPYuTlhw3xKke k5CresN7xiMhaK+xBxQ1/lygW903ktA= X-MC-Unique: kQdrm7puOF2j1nq8n6N21A-1 X-Mimecast-MFC-AGG-ID: kQdrm7puOF2j1nq8n6N21A_1762966462 To: devel@lists.libvirt.org Subject: [PATCH] qemu: snapshot: Set umask for 'qemu-img' when creating external inactive snapshots Date: Wed, 12 Nov 2025 17:54:18 +0100 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1wiunfE3uMrf7dIHBZ5z9Hw-PNE5h84SEitJHxjys-Q_1762966462 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GIUJY3RZASLZJABLFHNHQR7IB6K2X6W7 X-Message-ID-Hash: GIUJY3RZASLZJABLFHNHQR7IB6K2X6W7 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762966552124158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa External inactive snapshots are created by invoking 'qemu-img' which creates the file. Currently qemu-img creates image with mode 644 based on default umask as libvirt doesn't set any. Having a world-readable image is obviously wrong so set the umask to 0066 to have the file readable only by the owner. Resolves: https://bugs.debian.org/1120119 Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index d4994dd54e..6868910d9a 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -228,6 +228,9 @@ qemuSnapshotCreateQcow2Files(virDomainDef *def, NULL))) return -1; + /* ensure that new files are only readable by the user */ + virCommandSetUmask(cmd, 0066); + /* adds cmd line arg: backing_fmt=3Dformat,backing_file=3D/path/to= /backing/file */ virBufferAsprintf(&buf, "backing_fmt=3D%s,backing_file=3D", virStorageFileFormatTypeToString(defdisk->src->f= ormat)); --=20 2.51.1