From nobody Fri Dec 27 11:46:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732634358737439.9148042023312; Tue, 26 Nov 2024 07:19:18 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id A59AA1C4C; Tue, 26 Nov 2024 10:19:16 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2D0081900; Tue, 26 Nov 2024 10:17:19 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 554BF1B52; Tue, 26 Nov 2024 10:17:11 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9B14E18E2 for ; Tue, 26 Nov 2024 10:16:57 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-Tp5xIgBTOGWA2BGImDyWVg-1; Tue, 26 Nov 2024 10:16:53 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFC5A188EFFD for ; Tue, 26 Nov 2024 15:16:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 739D219776DB for ; Tue, 26 Nov 2024 15:16:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732634216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wiozSt15D4sGwmBbutTGgSae0vTbxLTa0a+aJb5UcM4=; b=Auau35bYzaeS0ri2fSUQNTgN3qGG0q04p/Px+IQH+5EubCKUazpyIOR8qw2IIIFgxilSvj 6R6aSh2cp3F8N6rc5P8GC9dtreZobY9af5ybQYmEjrC+51KCIoyQO6/IzmYF66CFjCfsf5 lPwO5bUh8d0c6HC1rEds5rBPZDl7M1o= X-MC-Unique: Tp5xIgBTOGWA2BGImDyWVg-1 X-Mimecast-MFC-AGG-ID: Tp5xIgBTOGWA2BGImDyWVg From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 3/8] qemuBlockReopenAccess: Don't require backing chain terminator for non-chained images Date: Tue, 26 Nov 2024 16:16:14 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q33JXCJ2GoEE4zJAL9QTbLfjuwgqSdFY2ott48YRHSE_1732634212 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7U6PKUUG6HK7DH5JEI7UVO4MNIWQCUYS X-Message-ID-Hash: 7U6PKUUG6HK7DH5JEI7UVO4MNIWQCUYS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732634360269019100 Content-Type: text/plain; charset="utf-8" Add an exception for image formats not supporting backing images so that they can be reopened RW/RO without the need for adding a terminating virStorageSource as they simply can't have a backing image. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index a7c8be8d8b..af317a1f1f 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3182,7 +3182,7 @@ qemuBlockReopenAccess(virDomainObj *vm, /* If we are lacking the object here, qemu might have opened an image = with * a node name unknown to us */ - if (!src->backingStore) { + if (src->format >=3D VIR_STORAGE_FILE_BACKING && !src->backingStore) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("can't reopen image with unknown presence of back= ing store")); return -1; --=20 2.47.0