From nobody Tue May 7 04:22:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571753120; cv=none; d=zoho.com; s=zohoarc; b=ZKvJgcVgQ0GWsggkKG09IfaBP88nHimMqkfRTEbXOWBFsZperJYDh5oiRk4kZsilty0dYkz/B15mdkSgZ8ZQWREPA8mm6BN3IKvHGQ0UWGZB4CkQHoQudlrZ4dvOnaETspNAex9j0+V99qhwv7CxdJFUAx7tMQFWe8eSsRWwfvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571753120; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8hTTWg4x2MCliDEQQAP74eCBhU6cN07qh1AL8cwL1Z8=; b=k0XjBkOM1l7icA0NBx4pW2omXm+TBLcOl9XTgmilIdT5iNG6CeSsjGjhohiPEvkb1HrLIZmy+TnhBErM+YyQmf8anvMz7eAq0N0DJbwDA2mzD1jgUi7ki0bQnw3Wb3u8DI9To2yBpBKLpnW0iOp+AU0NPVbGEYUvM/7eigPsMiM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1571753120507891.4686367288613; Tue, 22 Oct 2019 07:05:20 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-7BxpMACWNPWmh2ft5gNclw-1; Tue, 22 Oct 2019 10:00:13 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C50A2107AD31; Tue, 22 Oct 2019 14:00:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 542315D6A9; Tue, 22 Oct 2019 14:00:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 609D91803B54; Tue, 22 Oct 2019 14:00:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9ME04fN002355 for ; Tue, 22 Oct 2019 10:00:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 991FF5D6A9; Tue, 22 Oct 2019 14:00:04 +0000 (UTC) Received: from icr.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2100D5D70E for ; Tue, 22 Oct 2019 13:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571753119; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8hTTWg4x2MCliDEQQAP74eCBhU6cN07qh1AL8cwL1Z8=; b=GxG5wmmMeRCWtnGDaKU7s/wQPu4k9myvqV7c5hovm3m5xfM9xCsISdr0uwjcI9V1o7NSHr NNlR47pVVI2imH8q96+0wJcr+8fYYDbdcaVgE4dTNrX5wvyr51pkooxFOAibYnb8UTcNs+ o5MO250r7AIWfU5rRhvmsR/HFq2SsSE= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Tue, 22 Oct 2019 15:59:53 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] conf: remove NULL check from virDomainQemuMonitorEventNew X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 7BxpMACWNPWmh2ft5gNclw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The qemu_domain_monitor_event_msg struct in qemu_protocol.x defines event as a nonnull_string and qemuMonitorJSONIOProcessEvent also errors out on a non-NULL event. Drop the check to fix the build with static analysis. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Erik Skultety --- src/conf/domain_event.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 644f6eb595..33fbf10406 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -1934,20 +1934,12 @@ virDomainQemuMonitorEventNew(int id, 0, id, name, uuid, uuidstr))) return NULL; =20 - /* event is mandatory, details are optional */ - if (!event) - goto error; - ev->event =3D g_strdup(event); ev->seconds =3D seconds; ev->micros =3D micros; ev->details =3D g_strdup(details); =20 return (virObjectEventPtr)ev; - - error: - virObjectUnref(ev); - return NULL; } =20 =20 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list