From nobody Mon Feb 9 06:26:30 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1709911227170122.94416198303793; Fri, 8 Mar 2024 07:20:27 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id E25D91B8B; Fri, 8 Mar 2024 10:20:25 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 05C2C1BCA; Fri, 8 Mar 2024 10:15:55 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id A33CB1AE2; Fri, 8 Mar 2024 10:15:34 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6F07019E2 for ; Fri, 8 Mar 2024 10:15:32 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-UkU0nkuENieiVOJBZS1pNg-1; Fri, 08 Mar 2024 10:15:30 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0FDBF38049F6 for ; Fri, 8 Mar 2024 15:15:30 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.3.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC3CA1C05E1C for ; Fri, 8 Mar 2024 15:15:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: UkU0nkuENieiVOJBZS1pNg-1 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 2/4] ch: Demote error when CH driver fails to init Date: Fri, 8 Mar 2024 16:15:24 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: D2SQCEFXWE3THS3KHMKIXHM4H6KUJWBR X-Message-ID-Hash: D2SQCEFXWE3THS3KHMKIXHM4H6KUJWBR X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709911228099100001 If the host doesn't have /dev/kvm nor /dev/mshv, i.e. CH driver is unable to run any guests, then an error is reported. But the usual thing to do here is print an info message into the logs and return VIR_DRV_STATE_INIT_SKIPPED. It is a recoverable error after all. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/ch/ch_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 2601eea44b..9394924f2d 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -893,9 +893,8 @@ static int chStateInitialize(bool privileged, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_KVM= ) && !virCapabilitiesDomainSupported(ch_driver->caps, -1, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_HYP= ERV)) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("/dev/kvm and /dev/mshv are missing. CH driver fa= iled to initialize.")); - return VIR_DRV_STATE_INIT_ERROR; + VIR_INFO("/dev/kvm and /dev/mshv are missing. CH driver failed to = initialize."); + return VIR_DRV_STATE_INIT_SKIPPED; } =20 if (!(ch_driver->xmlopt =3D chDomainXMLConfInit(ch_driver))) --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org