From nobody Sun Feb 8 18:09:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593701227; cv=none; d=zohomail.com; s=zohoarc; b=e08A+CF0YaxWwFOV+WuIMrRoH/D8T6MF0sZxYXnvdSceMngY1VzqLRZ36McigWeqcTACSy+Tqg3Hde5Cjb5Dr4NyYnfoiHQmYZGwwMCzXdC41Y68xymcXBpEj0swZ1DTGhjfKSWtjwSWLQAmoATeqResNVBmrQIW+QzxJMkIonM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593701227; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hT+GWu96RlAZcYTRZDBw5KeSOCXeMjTI5x8gZI5ARJ8=; b=CEPGniuPKognqAkUtFkS96ABY19pPFZ/755ZvXL6qxhjL2er8rTU3f88WPezXUePPEMDgbJGc8yVYQhTdlc+5fyJJzK6AH0Z884q3x4r5whbZPQ771bPj+cPKS0bZ1BOm0VwH44RXzy0LZJcPuzpli3yZ/tBn1i9udAqSRpaEPs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 15937012275187.421122505602284; Thu, 2 Jul 2020 07:47:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471--OUSKHLSMPefGbrWA7mejQ-1; Thu, 02 Jul 2020 10:46:35 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39B8380183C; Thu, 2 Jul 2020 14:46:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A37873FF2; Thu, 2 Jul 2020 14:46:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DEC1C1800433; Thu, 2 Jul 2020 14:46:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 062EeR2G011790 for ; Thu, 2 Jul 2020 10:40:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id 352351002397; Thu, 2 Jul 2020 14:40:27 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id A572B10013D2 for ; Thu, 2 Jul 2020 14:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593701226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hT+GWu96RlAZcYTRZDBw5KeSOCXeMjTI5x8gZI5ARJ8=; b=VYnAoM2ORzVynKJQpXBVhsxu4c6M8weCclUo+VlKbK+YNdWrYTloAPlxlm3ueT/T3ekY6h Ptmtmm6MNQafbFBwcnJQUGQSxzyAQnrqTIcOLxPl9MrC+CUIIp9aqfeC1YUpbWSqtumxUm RISZsJFrV/gK6DD4hTrizfEFRWvMBO8= X-MC-Unique: -OUSKHLSMPefGbrWA7mejQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 12/24] conf: backup: Don't explicitly forbid backup of read-only disk Date: Thu, 2 Jul 2020 16:39:58 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Users may want to use this to create a full backup or even incremental if the checkpoints are pre existing. We still will not allow to create a checkpoint on a read-only disk as that makes no sense. https://bugzilla.redhat.com/show_bug.cgi?id=3D1840053 Signed-off-by: Peter Krempa Reviewed-by: Eric Blake --- src/conf/backup_conf.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 92106d8aaa..e9eea5af75 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -411,13 +411,6 @@ virDomainBackupDefAssignStore(virDomainBackupDiskDefPt= r disk, _("disk '%s' has no media"), disk->name); return -1; } - } else if (src->readonly) { - if (disk->store) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("backup of readonly disk '%s' makes no sense"= ), - disk->name); - return -1; - } } else if (!disk->store) { if (virStorageSourceGetActualType(src) =3D=3D VIR_STORAGE_TYPE_FIL= E) { if (!(disk->store =3D virStorageSourceNew())) --=20 2.26.2