From nobody Mon Feb 9 01:47:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670242664; cv=none; d=zohomail.com; s=zohoarc; b=A2dj3RyTA4lfU88hcF7vy8bBHoQx+v26cNgQ4uDw0wdEgkdUcTGmuBT044VeFJTIZGqB0/q4+rCUg7IubZeP+zChMNKgi34xAvZSVmnT2NvYoYQkKCptfG07wvh7ErMlbyV7VRbwQOQB9ZhuzNWq9Rec/fhSmtYwyubGLSBAY9I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670242664; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L+wOugPU8PDpaR92w1Q/y8srce3X+lCAxBKy7BKYQHg=; b=mkxUbzsIPga4966/plIvcmgGADyp0had+Jqx2L4vnakojO8oxoOG2+WdIMMU59XmknCQ1lNkHjWHhWNYpPjsQUSxom4yleztMXqHHE89bEpzjsxjBHrXZTexW1snh5eef7VFFTagxNc6rYugFObDCsiV2fWkktq8wgfHimTdFN8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1670242664882277.4477759506907; Mon, 5 Dec 2022 04:17:44 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-361-D9ZdlZWzNWCMwjq4LNd8aw-1; Mon, 05 Dec 2022 07:17:39 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D2CF894E9D; Mon, 5 Dec 2022 12:17:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE5652027062; Mon, 5 Dec 2022 12:17:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D4F6019465B9; Mon, 5 Dec 2022 12:17:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3C07D1946588 for ; Mon, 5 Dec 2022 12:17:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 204A940C2089; Mon, 5 Dec 2022 12:17:34 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B91D340C206B for ; Mon, 5 Dec 2022 12:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670242663; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L+wOugPU8PDpaR92w1Q/y8srce3X+lCAxBKy7BKYQHg=; b=eLcIPXprjnExD/FQ9uXgpc6YxN5gHoj++ZpghMGDdB80Aazusa5p++tHjvEa6KySTNalca /gzjREdqfO+iDCiktBR3o9OQZOkEzG1pu7ZL60lTuz3o/KkD7Ydm/SfOvZzQhHZ0Sf7/P1 RLk7U2gN9FD0OF4EmFCKqYT1QSadPSA= X-MC-Unique: D9ZdlZWzNWCMwjq4LNd8aw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/4] qemu_extdevice: Init paths in qemuExtDevicesPrepareDomain() Date: Mon, 5 Dec 2022 13:17:29 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670242666466100003 Content-Type: text/plain; charset="utf-8"; x-default="true" The path generation phase belongs conceptually into domain preparation phase and not host preparation. Move qemuExtDevicesInitPaths() call from qemuExtDevicesPrepareHost() into qemuExtDevicesPrepareDomain(). Signed-off-by: Michal Privoznik --- src/qemu/qemu_extdevice.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 3eaf6571a2..34454891f6 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -97,6 +97,9 @@ qemuExtDevicesPrepareDomain(virQEMUDriver *driver, int ret =3D 0; size_t i; =20 + if (qemuExtDevicesInitPaths(driver, vm->def) < 0) + return -1; + for (i =3D 0; i < vm->def->nvideos; i++) { virDomainVideoDef *video =3D vm->def->videos[i]; =20 @@ -134,9 +137,6 @@ qemuExtDevicesPrepareHost(virQEMUDriver *driver, virDomainDef *def =3D vm->def; size_t i; =20 - if (qemuExtDevicesInitPaths(driver, def) < 0) - return -1; - for (i =3D 0; i < def->ntpms; i++) { virDomainTPMDef *tpm =3D def->tpms[i]; =20 --=20 2.37.4