From nobody Mon Mar 23 23:26:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773219890; cv=none; d=zohomail.com; s=zohoarc; b=dJjC40nGi1s2f5VQBwQDrLHWubqZCTnhjDVUvctP9vlXlUq1p7q7DCPfCOaG8xH/WiFaCpPe/Z9AOJSRcsmahdDdQTLIUYmUyLvmlaGbPSTHG2auW1MpFrRaMSmvQNM7DlekUU2gUwFV+AB3EeWiPQeH0Dn0pOociUfpb8TKpM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773219890; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=ELtuB3SgDinwdmwKH+z5DkbW9dYGsRfFK4LjXDVk2w4=; b=ML+I5h37CJfuUmygPRvBm/42emtS5oNb0szeJlXF7CmvNH40wWOPaaXEoJ2rjXTzdcZpJd0zsV8yLtpePnTIExFAZ6blwguKCnZT9smrwPG5dsIaqL3sUWuj1jI2ripyqf2Fa6ztI5GurVXLWV8weP09AzaNERJcMxBUK+F1sR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1773219890038490.4943074675807; Wed, 11 Mar 2026 02:04:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 603C5418A7; Wed, 11 Mar 2026 05:04:50 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id C3D4241911; Wed, 11 Mar 2026 05:02:01 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EEB2C3F86C; Wed, 11 Mar 2026 05:01:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 52FAE3F896 for ; Wed, 11 Mar 2026 05:01:53 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-xF1pIezyP3a_QZfum88CiA-1; Wed, 11 Mar 2026 05:01:51 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D45B18002CF for ; Wed, 11 Mar 2026 09:01:50 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4E4371800361 for ; Wed, 11 Mar 2026 09:01:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773219712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ELtuB3SgDinwdmwKH+z5DkbW9dYGsRfFK4LjXDVk2w4=; b=Y8K975jVpK5RwFRRS/tDEQWLCWvK5cuUXNWHwiuoEnCVFYi1xL/o4PTCsD33SisDDxukWS 0Cgy4+lUawfHE6AywxbjS2+PCy8MqgbHc36wxIqqcUtQXjs/ISURIdnnhjU+1ev2Jq2YcM 558jDEnXns222X/Qne3jw+NLCDeMVFs= X-MC-Unique: xF1pIezyP3a_QZfum88CiA-1 X-Mimecast-MFC-AGG-ID: xF1pIezyP3a_QZfum88CiA_1773219710 To: devel@lists.libvirt.org Subject: [PATCH v2] scripts: dtrace2systemtap: Fix argument name extraction regex to avoid '*' in names Date: Wed, 11 Mar 2026 10:01:47 +0100 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 36PcP7Pn7Er86qVffngj1JIRL1PW5NwOQlkNGp342wk_1773219710 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7DBI3QULUCBPQOUSIQJ5DCPQBSFIKJMX X-Message-ID-Hash: 7DBI3QULUCBPQOUSIQJ5DCPQBSFIKJMX X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773219894191158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa When commit d249170bf609d2c modified the arguments of 'virNetTLSContextNew' which has a systemtap probe defined the 'dtrace2systemtap' script was no longer to correctly generate the definitions for it. First problem which stemmed from mis-detecting the string array argumment as string, which would use 'user_string' to extract it was fixed in cb33103c4afbce681. After that the generated probe is still not correct because it doesn't strip all the '*' from pointers and thus for double pointers it generates the following invalid definition: probe libvirt.rpc.tls_context_new =3D process("/usr/lib64/libvirt.so").ma= rk("rpc_tls_context_new") { ctxt =3D $arg1; cacert =3D user_string($arg2); cacrl =3D user_string($arg3); *cert =3D $arg4; *keys =3D $arg5; sanityCheckCert =3D $arg6; requireValidCert =3D $arg7; isServer =3D $arg8; } Leading to the following failure: # stap -ve 'probe oneshot {exit()}' parse error: expected literal string or number saw: operator '*' at /usr/share/systemtap/tapset/libvirt_probes-6= 4.stp:204:3 source: *cert =3D $arg4; ^ 1 parse error. To address the issue the regex extracting the arguments needs to optionally match any number of '*' instead of just one. Resolves: https://issues.redhat.com/browse/RHEL-153832 Fixes: cb33103c4afbce68134be112ecc5d0251e542650 Signed-off-by: Peter Krempa Reviewed-by: Jiri Denemark --- scripts/dtrace2systemtap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/dtrace2systemtap.py b/scripts/dtrace2systemtap.py index 361dab1075..12fc390bcd 100755 --- a/scripts/dtrace2systemtap.py +++ b/scripts/dtrace2systemtap.py @@ -127,7 +127,7 @@ for file in filelist: if re.match(r'''.*char\s\*[^\*].*''', arg) is not None: isstr =3D True - m =3D re.search(r'''^.*\s\*?(\S+)$''', arg) + m =3D re.search(r'''^.*\s\**(\S+)$''', arg) if m is not None: arg =3D m.group(1) else: --=20 2.53.0