From nobody Mon Feb 9 13:37:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617285288; cv=none; d=zohomail.com; s=zohoarc; b=hzYiCKW6IU2g3XajSLAeLrTeEA/Xdat/W36utCqTCXtBUDGgTiHQuzAGIrAQ8nYsZRz1hP7nT/1BKFtsfiD6UXYfu8voS6Wqck0/NokFYlm+YAoE8hse8ki+71sdKraxaeJG9Fe/9T3fa1WFK2glgB/+nqnFeUMY5EJ+wDQEZFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617285288; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fSSI6j5p66stLzoH07hHvH9GPgYcofwgvo7UgZodADQ=; b=Izh9ULFf2QWjeyEjU7jn2qUZpsw+Ec5J0kZIuYN0eggMENpufX9wJw8fHJDsmDx708Os0qs7qm+/Kk5iYhbNjrPbEpEkzN9NvOgJBGHwwH2693LWu8GuC8RuKScfJ9x0+Vbg4uBXv3MgmEL/sTyE3uTA2aFpZw03ZNBIXtkRGcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1617285288492868.7423083546626; Thu, 1 Apr 2021 06:54:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-XD9YSoPMPNuAUMrWu5-7GA-1; Thu, 01 Apr 2021 09:54:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E8171009E49; Thu, 1 Apr 2021 13:54:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 089C7614FC; Thu, 1 Apr 2021 13:54:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AA99D1809C83; Thu, 1 Apr 2021 13:54:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131Ds9DP023481 for ; Thu, 1 Apr 2021 09:54:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6CC1A1DB; Thu, 1 Apr 2021 13:54:09 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 815035C8AB for ; Thu, 1 Apr 2021 13:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617285287; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fSSI6j5p66stLzoH07hHvH9GPgYcofwgvo7UgZodADQ=; b=IA0/7zWAMfnBrJo6l9qPJpb8+QxcXzPRoJQW00VWV0DnCZsHJilyVM74UD6F0mCxp2J1cO onacAIDFr46lwOPz3vVGFaq+saLVIy07Y5m6aA5iqyAERyodDZnzGgQorXgb2+1hFIq9l0 G8YVeEJFNxGQnwuFEWmyPDnX6/EJV0o= X-MC-Unique: XD9YSoPMPNuAUMrWu5-7GA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 24/39] virStorageBackendZFSRefreshPool: Reduce scope of 'tokens' Date: Thu, 1 Apr 2021 15:52:23 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Declare it in the loop that actually uses it. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/storage/storage_backend_zfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backen= d_zfs.c index cab1fd1637..6fed25cf4d 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -216,7 +216,6 @@ virStorageBackendZFSRefreshPool(virStoragePoolObjPtr po= ol G_GNUC_UNUSED) size_t i; g_autoptr(virCommand) cmd =3D NULL; g_auto(GStrv) lines =3D NULL; - g_auto(GStrv) tokens =3D NULL; g_autofree char *name =3D g_strdup(def->source.name); char *tmp; @@ -246,13 +245,13 @@ virStorageBackendZFSRefreshPool(virStoragePoolObjPtr = pool G_GNUC_UNUSED) goto cleanup; for (i =3D 0; lines[i]; i++) { + g_auto(GStrv) tokens =3D NULL; size_t count; char *prop_name; if (STREQ(lines[i], "")) continue; - g_strfreev(tokens); if (!(tokens =3D virStringSplitCount(lines[i], "\t", 0, &count))) goto cleanup; --=20 2.29.2