From nobody Tue Sep 9 03:11:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17380670108698.652695808846829; Tue, 28 Jan 2025 04:23:30 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2459E1B35; Tue, 28 Jan 2025 07:23:30 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 58D4D18DE; Tue, 28 Jan 2025 07:22:49 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2F2EB17DB; Tue, 28 Jan 2025 07:22:46 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AE5B817BC for ; Tue, 28 Jan 2025 07:22:45 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-Lj9qEyHuN5S1eJUqC_BPSg-1; Tue, 28 Jan 2025 07:22:44 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 70CB31800374 for ; Tue, 28 Jan 2025 12:22:43 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AFF5818008C0 for ; Tue, 28 Jan 2025 12:22:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738066965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PeASdKOwDvMFDqeC695sdYO5mWo8LhOstKUz1xXZE3I=; b=HPlGp3PS5Ow/VeajJmYa1VkcIrSchJu9Rz0I5njX6CNnBwKifiEWrR0y0IzQ/rDt4O+3R+ JgeITVhtL1okaLEI0mrnS4vKMKpgpIX2Nc9CohM0zc1hnvJXatqcTe4sD90dwPwRkHhHnM oJ9LXQE2T5IGAIc6EJHVoN1jEo4jEhE= X-MC-Unique: Lj9qEyHuN5S1eJUqC_BPSg-1 X-Mimecast-MFC-AGG-ID: Lj9qEyHuN5S1eJUqC_BPSg From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 1/5] vbox: Use g_autofree in tryLoadOne() Date: Tue, 28 Jan 2025 13:22:35 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jvhZLAriCyQqUj7QdrL0K1W6e25IP1KkeHK3sPRBipI_1738066963 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XKQ3CGVCX5VCNHTQMW2HFWT7UCJC7Q6J X-Message-ID-Hash: XKQ3CGVCX5VCNHTQMW2HFWT7UCJC7Q6J X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738067011691019000 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Michal Privoznik --- src/vbox/vbox_XPCOMCGlue.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index 688211d122..e625492173 100644 --- a/src/vbox/vbox_XPCOMCGlue.c +++ b/src/vbox/vbox_XPCOMCGlue.c @@ -78,7 +78,7 @@ tryLoadOne(const char *dir, bool setAppHome, bool ignoreM= issing, unsigned int *version) { int result =3D -1; - char *name =3D NULL; + g_autofree char *name =3D NULL; PFNVBOXGETXPCOMCFUNCTIONS pfnGetFunctions; =20 if (dir !=3D NULL) { @@ -88,7 +88,6 @@ tryLoadOne(const char *dir, bool setAppHome, bool ignoreM= issing, if (!ignoreMissing) VIR_ERROR(_("Library '%1$s' doesn't exist"), name); =20 - VIR_FREE(name); return -1; } } else { @@ -152,8 +151,6 @@ tryLoadOne(const char *dir, bool setAppHome, bool ignor= eMissing, g_clear_pointer(&hVBoxXPCOMC, dlclose); } =20 - VIR_FREE(name); - return result; } =20 --=20 2.45.2