From nobody Mon Feb 9 12:11:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612186780; cv=none; d=zohomail.com; s=zohoarc; b=egelUm1DyCIlHpfWJ98/TLCZolc3QdqGunVeVuoqkb+cVLXQ20D/wnM+s/eYuhxC8O+UpkXz8GWSOHHiTjvl9mba/Z/74dqprDbAaTpNFYmm9KxBPPyukCUSbZCLHCdmP2PP4RxeaEwX9TnYjqrlMfApeskBJgVDp8NspMKZ3Cc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612186780; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C0Sw6NvMpNn/CtbX0f+Wp8+HtpcOBxaPvNSeeJKxfo8=; b=PHQxqYVcWEVPrVMGmHnC3El1fxtLf3sSua+rhVmilZwHJBMvsTDyLbd5/78W6fr5wOrYPqHfdDh90GjFF3336qJlw6VEPQjeU23NxewYj/cAFJKdgpJDuIahLHiapHkiRFJfyq2ifZiGDqfps4libiGd2oRgobj9iI3OghjKpsU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612186780139627.7061190327287; Mon, 1 Feb 2021 05:39:40 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-R5TAXbM1PD2SnTsBuQyFZw-1; Mon, 01 Feb 2021 08:39:36 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B94CCC623; Mon, 1 Feb 2021 13:39:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45A5160C68; Mon, 1 Feb 2021 13:39:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0DB2050044; Mon, 1 Feb 2021 13:39:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111DdUe9023549 for ; Mon, 1 Feb 2021 08:39:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8B9A360C6A; Mon, 1 Feb 2021 13:39:30 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id E4C1960C66 for ; Mon, 1 Feb 2021 13:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612186779; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=C0Sw6NvMpNn/CtbX0f+Wp8+HtpcOBxaPvNSeeJKxfo8=; b=E1VsF7pyn4dZ7Y2ooptgH+VhYQvDGSJW/bAIvbe9nPjAe2soORnJ/6u3DyJSxnDVAr+414 M/vXGYApMT8fU9MwRupscdNfoCxBIP35djAdBK96wufG+NGrN3W6+V4pYkPnVAWEgoJSLM fmcrivXROH7QfZaFF5Spf2u0AnMNn8o= X-MC-Unique: R5TAXbM1PD2SnTsBuQyFZw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 11/14] virCryptoEncryptDataAESgnutls: Use memset instead of VIR_DISPOSE_N Date: Mon, 1 Feb 2021 14:39:03 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Clear out the value using an explicit memset and free it with g_free so that VIR_DISPOSE_N can be phased out. Signed-off-by: Peter Krempa --- src/util/vircrypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/vircrypto.c b/src/util/vircrypto.c index c4874550af..82281a070a 100644 --- a/src/util/vircrypto.c +++ b/src/util/vircrypto.c @@ -206,7 +206,8 @@ virCryptoEncryptDataAESgnutls(gnutls_cipher_algorithm_t= gnutls_enc_alg, return 0; error: - VIR_DISPOSE_N(ciphertext, ciphertextlen); + memset(ciphertext, 0, ciphertextlen); + g_free(ciphertext); memset(&enc_key, 0, sizeof(gnutls_datum_t)); memset(&iv_buf, 0, sizeof(gnutls_datum_t)); return -1; --=20 2.29.2