From nobody Mon May 6 09:38:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642687190; cv=none; d=zohomail.com; s=zohoarc; b=gFHaD+H/Uehy9U4knaUxIxdUPEV9IRJOA8E2cZOAYvByz0KnZUBmty/sMaLI4h1hJmGG/9O1dJe72YFE8UQt1zVjtO6cmJZgDljJUkktF4c1armiMpM0O9s/BCaY7a6kmDOtWt3vpw/a856q/X/xOYcIQLuT4hSSPrbd1JdO6A4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642687190; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=LjxinLsBYxmT5DCJnykMyLGpxVmTI9CKkkNUUGHvkTg=; b=jhX6pYVdQ+Nx30AjzRfBGKBk3kVKQPWLJLIQewEZToA7RxKW6qmmGOgisxDE0gxkvv0XhbMRsScN9prWOwkeGRgbLNQOmF2HfTqF3zJTZkA7gDqkHTYeaUuwT3vg6EXGqGmkbGQzhh+a5UA33cR2O3Wo9Uv8wJpXmuHw0lcLWFc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642687190852493.9631508273053; Thu, 20 Jan 2022 05:59:50 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310-vb4iK86bOUitGuU3wIbpYA-1; Thu, 20 Jan 2022 08:59:47 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC86F1083F62; Thu, 20 Jan 2022 13:59:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8995A7B6F7; Thu, 20 Jan 2022 13:59:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B8C74A705; Thu, 20 Jan 2022 13:59:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20KDxcMf012269 for ; Thu, 20 Jan 2022 08:59:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id B3ABDB189D; Thu, 20 Jan 2022 13:59:38 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1736A7B6FB; Thu, 20 Jan 2022 13:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642687189; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LjxinLsBYxmT5DCJnykMyLGpxVmTI9CKkkNUUGHvkTg=; b=OgvTJ/Z4QZPr/j8fGYzdSetfEGDNa752TGKjcwhc13oGyE0UR3uUxJssuqbxYU1yBbNO0D WQnvwZ0SmxOGiom2qjQlLE83yuclGUMnWXoEy6CriSVTqVrdeax6/EnADL9krOfRUNzyXH k4oosddPsvxP30PK3pXUPWxdCSR+DHI= X-MC-Unique: vb4iK86bOUitGuU3wIbpYA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: fix inactive snapshot revert Date: Thu, 20 Jan 2022 14:59:22 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642687192463100001 https://bugzilla.redhat.com/show_bug.cgi?id=3D2039136 Fixes: 85e4a13c3f19078fb6af5ffb4a80022c142cbc7e Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 9cf185026c..1887c70708 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2190,7 +2190,7 @@ qemuSnapshotRevertInactive(virDomainObj *vm, =20 if (*inactiveConfig) { virDomainObjAssignDef(vm, inactiveConfig, false, NULL); - return -1; + defined =3D true; } =20 if (flags & (VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING | --=20 2.31.1