From nobody Sun Feb 8 18:30:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407230; cv=none; d=zohomail.com; s=zohoarc; b=RtFKzTTTbT5Oo1tQl9xXhgVSsyxguUM0QFg3JBhx0WaOC0cqxKWetmMfb2Qchv10sze3ebLQzafAfowUyXKOa1wwIbUY4LeehUQBNPbEFLpYpB0X8lRAM4DKOnu2sqdneDBCvqzcQsOnzqHZi+6SXNxoaemwCcENoPACbufPmeA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407230; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lmRCPxMa4WljxoloMffUDWcOKqAYZa/YRS/rL3+rx3Y=; b=Tssr52MaZ6L+BW7BmBbLwdeAHPu8oGA92K9209dERbwYyoQtGbSlqjucn0MVFBrmNioA97rpu6gNN+uzrFnMWnVU6uypNXozkjXRoL6xMrXUYDb6Qgwko/wc5ZIbeRDVMlgyhXqkPnb4bCh0lJVecV7m0PZs3uvJm6xMRqbyP/U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1596407230344693.0693514611643; Sun, 2 Aug 2020 15:27:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-BhjNNiCgN7WZw5-mM7SKoQ-1; Sun, 02 Aug 2020 18:25:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1B5A800473; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B571B88F22; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 866581806B0D; Sun, 2 Aug 2020 22:25:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MPkaV011990 for ; Sun, 2 Aug 2020 18:25:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9AFB587E2C; Sun, 2 Aug 2020 22:25:46 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id E121C87E2B for ; Sun, 2 Aug 2020 22:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407229; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lmRCPxMa4WljxoloMffUDWcOKqAYZa/YRS/rL3+rx3Y=; b=NXsctCWDd8Z71rk+Zh0VcJ+qSufJyKNyve3gEs7tHp8a5nkpA+HZoEacZZxvmEeD0LCjkY EV0hUZPTHV7CBW5asamgnAYgt/J/JrrHFoL4j1MQkyWK3fbkbn4zivMfxR7nKRp6ZCHLV6 2c6UxkLtpz5E9zUOSg0l0O1HkPZFUAQ= X-MC-Unique: BhjNNiCgN7WZw5-mM7SKoQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/6] util: delete virStringListFree Date: Mon, 3 Aug 2020 00:25:34 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Now that everything uses g_strfreev, this function is no longer needed. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/libvirt_private.syms | 1 - src/util/virstring.c | 18 ------------------ src/util/virstring.h | 1 - 3 files changed, 20 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index eea31a736d..53d0e02433 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -3216,7 +3216,6 @@ virStringIsEmpty; virStringIsPrintable; virStringListAdd; virStringListAutoFree; -virStringListFree; virStringListFreeCount; virStringListGetFirstWithPrefix; virStringListHasString; diff --git a/src/util/virstring.c b/src/util/virstring.c index b31d4743f2..c31f2ede8f 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -259,24 +259,6 @@ virStringListMerge(char ***dst, } =20 =20 -/** - * virStringListFree: - * @strings: a NULL-terminated array of strings to free - * - * Frees a NULL-terminated array of strings, and the array itself. - * If called on a NULL value, virStringListFree() simply returns. - */ -void virStringListFree(char **strings) -{ - char **tmp =3D strings; - while (tmp && *tmp) { - VIR_FREE(*tmp); - tmp++; - } - VIR_FREE(strings); -} - - void virStringListAutoFree(char ***strings) { if (!*strings) diff --git a/src/util/virstring.h b/src/util/virstring.h index 462a6c092c..7e6103c9d2 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -47,7 +47,6 @@ void virStringListRemove(char ***strings, int virStringListMerge(char ***dst, char ***src); =20 -void virStringListFree(char **strings); void virStringListAutoFree(char ***strings); void virStringListFreeCount(char **strings, size_t count); --=20 2.26.2