From nobody Mon Feb 9 04:27:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612285038; cv=none; d=zohomail.com; s=zohoarc; b=SCKdKn5F8tdW1wZGXqwYLR+zrdM746oDHG5gI9Ku9zwaHXTUjazdOICQLFx25T+Xuk7Uo1EQcQ+UuexszxfwefU2kyFledqqxAmRsT9KX70XZzHj57F91k0niTtUBZoqPMBNSufo+9ZvEiTLNJ5ndPUXscJS9sgFE5z5F09n4xU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612285038; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UizPWiL3MsSp1hXNWDzUCWsB3exVQQmqnCWl2FjbW0E=; b=f18RWLrA6v9XwQzdaecmJ9tj0XdmLFJebuc1xoDPT2PxHH3CZjcGv6Tmnstas09bjv0trsgk27Mzefku8i0SyrmTU7NjZIXknsTf0H3Jt4oRaoLHkpZN6KFTXbh3o/qVpNFlpuSnSFZ08A8T7rQHT7J4m5g4BHRoCUvPNwI8R5A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612285038291558.645639725442; Tue, 2 Feb 2021 08:57:18 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-60sKzMyyN_yEIvqD7B4EPA-1; Tue, 02 Feb 2021 11:56:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 825ED10CE785; Tue, 2 Feb 2021 16:56:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F9AD5C72F; Tue, 2 Feb 2021 16:56:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DFCAD18095CE; Tue, 2 Feb 2021 16:56:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 112GuGMK014876 for ; Tue, 2 Feb 2021 11:56:16 -0500 Received: by smtp.corp.redhat.com (Postfix) id D7D866E510; Tue, 2 Feb 2021 16:56:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EA9E60862 for ; Tue, 2 Feb 2021 16:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612285037; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UizPWiL3MsSp1hXNWDzUCWsB3exVQQmqnCWl2FjbW0E=; b=WQgQ2M3AgY/NEWo+LmywOYm+g40cLfARMVhRfLVCAa22Z7nD3v1yzJwpOmDt+z8Fuw3N3W 1rr4D797RuvVY5GNmuIEEOipvbvpqiKtmKv44JMB7fVy/gBreTm6z3t0U5NjDOek3FO+yn FedQqjQf5mBWuYqeR1R+WcyNUUjUyNQ= X-MC-Unique: 60sKzMyyN_yEIvqD7B4EPA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 02/27] libxlMakeDomBuildInfo: Don't use VIR_DISPOSE_N for USB device list Date: Tue, 2 Feb 2021 17:55:39 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The list isn't secret which would need being disposed of. Just expand the array and return failure when adding the NULL terminator similarly to how we expand the list for adding devices in a loop. Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libxl/libxl_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 6a8ae27f54..cb1fd7df7d 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -686,7 +686,6 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, /* NULL-terminate usbdevice_list */ if (nusbdevice > 0 && VIR_EXPAND_N(b_info->u.hvm.usbdevice_list, nusbdevice, 1) < 0)= { - VIR_DISPOSE_N(b_info->u.hvm.usbdevice_list, nusbdevice); return -1; } #endif --=20 2.29.2