From nobody Sat Apr 20 08:32:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565712529; cv=none; d=zoho.com; s=zohoarc; b=jVDlOnWh6NPe5BIxQlmQfTRARZeE71plYLIZxgdtZSBoYqX3jbq+rIh8eP7NyVDHpWPokN0IbrrC5PWQKWOrOyyIpy3glsPT2KekCSO/WkNh2Cgzl4vm6qXkbdf+2ouuAQMEzCNXWkUAuSEpT0qBKolod0SF5Qy/KAFGvS7/arQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565712529; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=v2NPj7IvCxgm8MrKL7dopbU/CmBFNZRsV+pN4gPWXIg=; b=Wkksx9SqQaJWIqsfNgDL///vcNedV50nbf7IskoOoSXBppezAHQjuXVaQRm+ZTL5Nk98UDwKTKkVbvZSScNb1utKk2JZ8m2hMh4t8oyFGvSxgGD8As2x/sgWq5hPi89uj7YRya2yfxMlnqO5teIeHmMlVGBBWplhGHeNqug30+8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1565712529744664.541643176371; Tue, 13 Aug 2019 09:08:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2747FEEF10; Tue, 13 Aug 2019 16:08:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E47517FB95; Tue, 13 Aug 2019 16:08:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9F1C2E203; Tue, 13 Aug 2019 16:08:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7DG8hVa011749 for ; Tue, 13 Aug 2019 12:08:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 52E2C1001281; Tue, 13 Aug 2019 16:08:43 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2826F1000323 for ; Tue, 13 Aug 2019 16:08:40 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 46D2B104C7C; Tue, 13 Aug 2019 18:08:39 +0200 (CEST) From: Jiri Denemark To: libvir-list@redhat.com Date: Tue, 13 Aug 2019 18:08:38 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] qemu: Allow migration with disk cache on X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 13 Aug 2019 16:08:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" When QEMU supports flushing caches at the end of migration, we can safely allow migration even if disk/driver/@cache is not none nor directsync. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 2bd1a464bf..bd40a8e70d 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1214,6 +1214,7 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver, =20 static bool qemuMigrationSrcIsSafe(virDomainDefPtr def, + virQEMUCapsPtr qemuCaps, size_t nmigrate_disks, const char **migrate_disks, unsigned int flags) @@ -1264,6 +1265,11 @@ qemuMigrationSrcIsSafe(virDomainDefPtr def, disk->cachemode =3D=3D VIR_DOMAIN_DISK_CACHE_DIRECTSYNC) continue; =20 + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE))= { + VIR_DEBUG("QEMU supports flushing caches; migration is safe"); + continue; + } + virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s", _("Migration may lead to data corruption if disks" " use cache other than none or directsync")); @@ -1971,7 +1977,8 @@ qemuMigrationSrcBeginPhase(virQEMUDriverPtr driver, goto cleanup; =20 if (!(flags & (VIR_MIGRATE_UNSAFE | VIR_MIGRATE_OFFLINE)) && - !qemuMigrationSrcIsSafe(vm->def, nmigrate_disks, migrate_disks, fl= ags)) + !qemuMigrationSrcIsSafe(vm->def, priv->qemuCaps, + nmigrate_disks, migrate_disks, flags)) goto cleanup; =20 if (flags & VIR_MIGRATE_POSTCOPY && @@ -4583,7 +4590,8 @@ qemuMigrationSrcPerformJob(virQEMUDriverPtr driver, goto endjob; =20 if (!(flags & (VIR_MIGRATE_UNSAFE | VIR_MIGRATE_OFFLINE)) && - !qemuMigrationSrcIsSafe(vm->def, nmigrate_disks, migrate_disks, fl= ags)) + !qemuMigrationSrcIsSafe(vm->def, priv->qemuCaps, + nmigrate_disks, migrate_disks, flags)) goto endjob; =20 qemuMigrationSrcStoreDomainState(vm); --=20 2.22.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list