From nobody Mon Feb 9 16:54:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1632411476; cv=none; d=zohomail.com; s=zohoarc; b=K+/SNyhUahxdn/I8OqKWiAWRah1HJJ6IOQVStujwU12ZDTc3xbusCnxljLosJLdo/v8B3cvl+bXd/kIDxjjw3/RXGKXEycSCieh7LF0KFcZekcosoV28pR4UNuR8q/K+pr93oTAwPbzz67J449vzDUOvbtEUdLjPAcERSj7r5zE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632411476; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C0ZOkFC5dMgIH7XcyBU/duFKRRmHo+5QCvormsHtqVo=; b=h1rtLwF0eTrvwAHQDLORB5quouzV0j/5RaRoNo93cruK1JL60i4/FQqaz9tk8gD1pbSArxMtW3uo0aA1qu870TngDwfaQ7ID8Xr/nsjHpvN3Kru8XEkq+z3ct5XEohYX3Znyqr1bWqdpxQpMK1c5H3WpiKfGDg63E/If/u4nofQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163241147677575.02125057772344; Thu, 23 Sep 2021 08:37:56 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-2peRVoYoPJy64-F8I-Q0ow-1; Thu, 23 Sep 2021 11:37:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 554195074D; Thu, 23 Sep 2021 15:37:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 13D2A1800D; Thu, 23 Sep 2021 15:37:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D6FE84EA2A; Thu, 23 Sep 2021 15:37:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18NFbO47000470 for ; Thu, 23 Sep 2021 11:37:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id C19EE10D8245; Thu, 23 Sep 2021 15:37:24 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC5F510D2CF4 for ; Thu, 23 Sep 2021 15:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632411475; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=C0ZOkFC5dMgIH7XcyBU/duFKRRmHo+5QCvormsHtqVo=; b=gSU0UeVNlBgwFLi0A/qTf5gdQiJiokJ5fcuEJh+VYqicm5abQSEkhFzAeaGGWRP/Rr5MLU FdpFoPc9eYOIWkUMtyHg9dOfpp+13hIaZ33um0tE4O+HPyEogPEFOhxaLHkVa9Hheqq/tp p6gXMtHbhMrKyabH4wPaHja96y1zSJI= X-MC-Unique: 2peRVoYoPJy64-F8I-Q0ow-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/14] qemuxml2argvtest: Use real caps in "graphics-vnc-tls" case Date: Thu, 23 Sep 2021 17:37:07 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1632411478901100001 Content-Type: text/plain; charset="utf-8" Replace the fake caps invocation with invocation bidnig it to the oldest supported qemu version. Signed-off-by: Peter Krempa --- ...s-vnc-tls.args =3D> graphics-vnc-tls.x86_64-2.11.0.args} | 8 +++++--- tests/qemuxml2argvtest.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) rename tests/qemuxml2argvdata/{graphics-vnc-tls.args =3D> graphics-vnc-tls= .x86_64-2.11.0.args} (71%) diff --git a/tests/qemuxml2argvdata/graphics-vnc-tls.args b/tests/qemuxml2a= rgvdata/graphics-vnc-tls.x86_64-2.11.0.args similarity index 71% rename from tests/qemuxml2argvdata/graphics-vnc-tls.args rename to tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.11.0.args index 34559c0d25..5c1e7780d9 100644 --- a/tests/qemuxml2argvdata/graphics-vnc-tls.args +++ b/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.11.0.args @@ -12,7 +12,7 @@ SASL_CONF_PATH=3D/root/.sasl2 \ -name guest=3DQEMUGuest1,debug-threads=3Don \ -S \ -object secret,id=3DmasterKey0,format=3Draw,file=3D/tmp/lib/domain--1-QEMU= Guest1/master-key.aes \ --machine pc,accel=3Dtcg,usb=3Doff,dump-guest-core=3Doff \ +-machine pc-i440fx-2.11,accel=3Dtcg,usb=3Doff,dump-guest-core=3Doff \ -m 214 \ -realtime mlock=3Doff \ -smp 1,sockets=3D1,cores=3D1,threads=3D1 \ @@ -25,7 +25,9 @@ SASL_CONF_PATH=3D/root/.sasl2 \ -no-shutdown \ -no-acpi \ -boot strict=3Don \ --usb \ --vnc 127.0.0.1:3,tls,x509verify=3D/etc/pki/libvirt-vnc,sasl \ +-device piix3-usb-uhci,id=3Dusb,bus=3Dpci.0,addr=3D0x1.0x2 \ +-object tls-creds-x509,id=3Dvnc-tls-creds0,dir=3D/etc/pki/libvirt-vnc,endp= oint=3Dserver,verify-peer=3Don \ +-vnc 127.0.0.1:3,tls-creds=3Dvnc-tls-creds0,sasl=3Don \ -device cirrus-vga,id=3Dvideo0,bus=3Dpci.0,addr=3D0x2 \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index c696424f8f..c3ba9df9af 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1479,7 +1479,7 @@ mymain(void) DO_TEST("graphics-vnc-sasl", QEMU_CAPS_VNC, QEMU_CAPS_DEVICE_CIRRUS_VG= A); driver.config->vncTLS =3D 1; driver.config->vncTLSx509verify =3D 1; - DO_TEST("graphics-vnc-tls", QEMU_CAPS_VNC, QEMU_CAPS_DEVICE_CIRRUS_VGA= ); + DO_TEST_CAPS_VER("graphics-vnc-tls", "2.11.0"); DO_TEST_CAPS_LATEST("graphics-vnc-tls"); driver.config->vncTLSx509secretUUID =3D g_strdup("6fd3f62d-9fe7-4a4e-a= 869-7acd6376d8ea"); DO_TEST_CAPS_VER("graphics-vnc-tls-secret", "5.2.0"); --=20 2.31.1