From nobody Sun Feb 8 12:42:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639404048; cv=none; d=zohomail.com; s=zohoarc; b=imaqOK8ki3Q7hal1aN5iBPoxxFW6T3Flpz8NpBAooAH3VYPQO2RHmnR427TMe3mUMXMgPzdRf9+wWRg/sT44AiukGubRDAtHcbl/LOQ2z9FCDsVYvj7Z5SJS27f+2U9RMzDyKp++QY2U0BHpAq12am/RtjsNQ47UypDCifIPmcM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639404048; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x8JjsdAIKBo/PqUHDrc+xQ9Ja8hwDVybhaJFH2Xm4Mk=; b=RmJHGfjNAsaKo1JXWi1bJIr9WYpH9ZVt/jPOJfjgr18xJAV33J1xLcADa8pBZrqkP6loJGBEFiZrFEsB0eF2/zw+Pz+5LdU5ZaTqYLeA6oNnpoAdX0Sa9lYa5FVm4Vc/zK+P4m5urfwOjSEaVa9A5MKly/oE0ZBIpK0d/B98roc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1639404048945403.64315324948825; Mon, 13 Dec 2021 06:00:48 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-400-NDZM7CclNqeZldTlYnZJ6w-1; Mon, 13 Dec 2021 09:00:42 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5FFD2802E67; Mon, 13 Dec 2021 14:00:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D11AADCB; Mon, 13 Dec 2021 14:00:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 093591802E2C; Mon, 13 Dec 2021 14:00:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BDDxtBh002602 for ; Mon, 13 Dec 2021 08:59:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id B455222DFC; Mon, 13 Dec 2021 13:59:55 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B0D416A31 for ; Mon, 13 Dec 2021 13:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639404047; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x8JjsdAIKBo/PqUHDrc+xQ9Ja8hwDVybhaJFH2Xm4Mk=; b=SmI5twTuUFDGJaQjfaGKLpHDwU9IRKto4aJ329HZ735pu1jQOTbbGe5rvyIRQUsXz7vaUI bHZrH71aZR4zzRM5+1Hw+PRSjaHdlqKvaIxPJho9z3JTMYYJfhx4tBldKpErm/biZueKVV 7F4SJjk7y5fCa22fPV8KAH705mD97Yo= X-MC-Unique: NDZM7CclNqeZldTlYnZJ6w-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 12/14] storage: util: steal cmd in CreateQemuImgCmdFromVol Date: Mon, 13 Dec 2021 14:59:41 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639404059630100006 Signed-off-by: J=C3=A1n Tomko --- src/storage/storage_util.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index ce61f37172..bfc3edb1fd 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -1116,7 +1116,7 @@ virStorageBackendCreateQemuImgCmdFromVol(virStoragePo= olObj *pool, const char *inputSecretPath, virStorageVolEncryptConvertStep c= onvertStep) { - virCommand *cmd =3D NULL; + g_autoptr(virCommand) cmd =3D NULL; struct _virStorageBackendQemuImgInfo info =3D { .format =3D vol->target.format, .type =3D NULL, @@ -1246,11 +1246,10 @@ virStorageBackendCreateQemuImgCmdFromVol(virStorage= PoolObj *pool, } VIR_FREE(info.secretAlias); =20 - return cmd; + return g_steal_pointer(&cmd); =20 error: VIR_FREE(info.secretAlias); - virCommandFree(cmd); return NULL; } =20 --=20 2.31.1