From nobody Wed Apr 15 04:17:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1692005886; cv=none; d=zohomail.com; s=zohoarc; b=RGD/qCN5fmJOLd6P7TFcTb1EdEUX/HDK4UQD3KbWiuzVbEdU431pGpJ/ABz/LJYbubgaqJczPQCIitX6jaxjKzbBnvZQwgzRBtY7hXnT8CFdt+uhGqnuVyZacWx+nncx2xpZtIKUMZDlKa1FVBJF3hcOzRY1p2h/2LxjGtRznew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692005886; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z4pb2bE4f5E9ySWMjXkWTx6z2l9YnP7NzDtrfc9olNk=; b=gqCWdVN5UYghdtBYQb40ksbY8i1SRoeFRIezMEegLC6GfbMEwrZ9feco7zkPoYGFm6Jz3QODT0EbqF4bH+Tr88/O74i4GeBYT7//vRwC7Jtrh865CjtctwWqhGrGsJ5AQb9vtj+sJrRlMRrWKzmcfbwM/ZOF6HrbbL5yukj/G3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1692005886878390.7136563510554; Mon, 14 Aug 2023 02:38:06 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-PBX2LL3FP42lFptTi0AGKw-1; Mon, 14 Aug 2023 05:37:09 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84F1380CC35; Mon, 14 Aug 2023 09:37:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CE94C16029; Mon, 14 Aug 2023 09:37:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6F99E19451D1; Mon, 14 Aug 2023 09:36:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A1B5F19465B6 for ; Mon, 14 Aug 2023 09:36:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EF4E440B4CD3; Mon, 14 Aug 2023 09:36:33 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.45.226.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91C8C40B4CD0 for ; Mon, 14 Aug 2023 09:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692005885; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Z4pb2bE4f5E9ySWMjXkWTx6z2l9YnP7NzDtrfc9olNk=; b=YryW6sKersYu8vmMbayvMcYAFYrJvSoaghZ/j5J2Cz2NjAjI2eGRKC1kkKTWbn1205qRbN HhT9HDhQ0XavtSpqaPa0iSvRs8R+sIEbvvrp4PUe0xqlEiOqZj+wQokpqRmyXURougYnYT H+zvB6PyXusgbE4knFf8Sb1Mlti712M= X-MC-Unique: PBX2LL3FP42lFptTi0AGKw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 25/25] qemu_snapshot: allow snapshot revert for external snapshots Date: Mon, 14 Aug 2023 11:36:17 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1692005888295100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Now that the support to revert external snapshots is implemented we can drop this check. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 692d88e24d..d943281e35 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1892,12 +1892,6 @@ qemuSnapshotRevertValidate(virDomainObj *vm, return -1; } =20 - if (virDomainSnapshotIsExternal(snap)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("revert to external snapshot not supported yet")); - return -1; - } - if (!snap->def->dom) { virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, _("snapshot '%1$s' lacks domain '%2$s' rollback inf= o"), --=20 2.41.0