From nobody Thu Mar 28 08:53:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589879113; cv=none; d=zohomail.com; s=zohoarc; b=L5B7+JbRnnU0A3f3RM2Grn9Pg1wa0KzehlZZTPgBBLa7agIC8/Qa9/+qcip8hHtxun+PKyEA1XcJcVe/U6BumTjdGqYvYWjyjCd5F7Vyxeb8K8bfix/f5UwdKRf9FvoasvoPprr2RDDRsOc6EroQResz2phKYqpGoATcCn0DDis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589879113; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=HKY9vuVPWOjAqpwVpVW0EpduzauXFha3Wk1JBNp4e3g=; b=OaxavH0ZS1trKea0AsoiOhjUq7Cg1PT8YdsfwuhUY2FcVvkFnaY+Kt7GL+FqHsM3lJDSzQr0w4zuJFavqVLaoKyrAAXwaIzyMx0IXL6EvEZbPPnZHtpv+kIrwirn4Ejxw5gmCUr5+KSxmIt25onrD1VYxWmyAlqd2Gea4xnLJTI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1589879113364430.5108251619764; Tue, 19 May 2020 02:05:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-KaGKzsRHMme49qDG9mc2ww-1; Tue, 19 May 2020 05:00:45 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F8FE107ACF9; Tue, 19 May 2020 09:00:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43F71105B1EB; Tue, 19 May 2020 09:00:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 56B061809543; Tue, 19 May 2020 09:00:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04J90aPW002949 for ; Tue, 19 May 2020 05:00:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id CE2632D1D8; Tue, 19 May 2020 09:00:36 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id E598678900 for ; Tue, 19 May 2020 09:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589879112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HKY9vuVPWOjAqpwVpVW0EpduzauXFha3Wk1JBNp4e3g=; b=b09q1t1av+jGlAK3+VFd09X9N6GjX/kJ+ZIEVvkqzUY9A/1adUwuzlE/GHC6I8lLe4NSYF 7I07R39BmIAdrByCy9N56vOTqk/huOyozKA2bHb5VkzkkbCMFT7cxvR0EIOmq47zCx8gv6 4ki8e/5zoi1UARrgdjncXEn6jZK304w= X-MC-Unique: KaGKzsRHMme49qDG9mc2ww-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: conf: fix stray comma Date: Tue, 19 May 2020 11:00:25 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The qemu.conf change broke our augeas test: qemu/test_libvirtd_qemu.aug:96.3-203.1:exception thrown in test qemu/test_libvirtd_qemu.aug:96.8-.34:exception: Iterated lens matched less = than it should Lens: ../../src/qemu/libvirtd_qemu.aug:170.13-.43: Last match: ../../src/qemu/libvirtd_qemu.aug:18.52-.113: Not matching: ../../src/qemu/libvirtd_qemu.aug:12.19-.31: Error encountered at 48:27 (1615 characters into string) <\n "/dev/ptmx", "/dev/kvm"|=3D|,\n]\nsave_image_format =3D "raw> Fixes: ab5ba57012e9e6ab4f55afdeecd1813dd3ca916b Signed-off-by: J=C3=A1n Tomko --- Pushed as a trivial build fix src/qemu/qemu.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index d7a3f40e78..404961c53e 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -494,7 +494,7 @@ #cgroup_device_acl =3D [ # "/dev/null", "/dev/full", "/dev/zero", # "/dev/random", "/dev/urandom", -# "/dev/ptmx", "/dev/kvm", +# "/dev/ptmx", "/dev/kvm" #] # # RDMA migration requires the following extra files to be added to the lis= t: --=20 2.25.4