From nobody Sat Feb 7 05:49:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680004703; cv=none; d=zohomail.com; s=zohoarc; b=Jt9pbBwAS4jqBkXR3lpo8+evnRsmHXrI3o2eBOwq7LaHgONmynBO4+KtsxqZ+lyGkLmOMx7SQ9b/XoaUBr9fipMM37TU7mBErSpVpB579ekDKsED6UuVcYoltex/5gAIwD68xNE8kQHLMAdPGHS/bcYaGS65ltIf1UmP4GY2Bec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680004703; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jL2VKgCQlShIvEY+WEWPiA/EE3+xsIzY0i5RRnZEh3k=; b=lWsBq/DxgA3InHbNS5xBxvt6wkZOB5xIj00L9z+HeauuvHOFGZJViaP64s3YAwOEnvf5/BtiRNCqUBB+TxeKlOHQnSpTvFuojHVMgZhkHfmYXlq4HJ0n4EKYOA3eUJrPHEAif2xJiFLquf7pZYMNeQa98Fb+cN7E3tq7w9SgFd4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1680004703070740.8198181429126; Tue, 28 Mar 2023 04:58:23 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-338-E180GBY7PIef9TnsIxxqZA-1; Tue, 28 Mar 2023 07:58:17 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25ED6280D595; Tue, 28 Mar 2023 11:58:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DFA4D14171BB; Tue, 28 Mar 2023 11:58:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 92715194658D; Tue, 28 Mar 2023 11:58:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EA4CC194658C for ; Tue, 28 Mar 2023 11:58:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C78261121333; Tue, 28 Mar 2023 11:58:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F06D1121330 for ; Tue, 28 Mar 2023 11:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680004702; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jL2VKgCQlShIvEY+WEWPiA/EE3+xsIzY0i5RRnZEh3k=; b=cesy40RoWSWFEVRQsSxYG84GY2E0g0/VuqewDIRaMrM0HHp4AIuFVdAdg1ilE/aqt1n7ix uLHCmTty7NPC6Rxea5QVZplgeICJ+C+kQ2jP56rp05xb8sTF8NiwEJrAwQT0zS5bUXjedb ZFN/cIQUCD85w6RgY6SaPuJAVsxJDNo= X-MC-Unique: E180GBY7PIef9TnsIxxqZA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v1 1/3] conf: Introduce
for virtio-mem and virtio-pmem Date: Tue, 28 Mar 2023 13:58:01 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680004704667100002 Content-Type: text/plain; charset="utf-8"; x-default="true" Both virtio-mem and virtio-pmem devices have '.memaddr' attribute which controls the address where they are mapped in the guest memory. Ideally, users do not need to specify this as QEMU does the right thing and computes addresses automatically on startup. But soon, we will need to record this address as it is part of guest ABI. And also, there might be some users that want to control this value. Now, we are in a bit of a pickle, because both these device types already have a PCI address, therefore we can't just use
blindly. But what we can do, is introduce
under the element. This is also more conceptual, as knobs under control guest visible config of memory device (and .memaddr surely falls into that category). NB, SgxEPCDeviceInfo struct in QMP definition also has .memaddr attribute, but because of the way we build cmd line there's no (easy) way to set the attribute. So ignore that for now. Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzander --- docs/formatdomain.rst | 7 ++++++ src/conf/domain_conf.c | 24 ++++++++++++++++++- src/conf/domain_conf.h | 2 ++ src/conf/domain_validate.c | 6 +++++ src/conf/schemas/domaincommon.rng | 7 ++++++ .../memory-hotplug-virtio-mem.xml | 1 + .../memory-hotplug-virtio-pmem.xml | 1 + 7 files changed, 47 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 27f83e254d..092d2296d5 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8100,6 +8100,7 @@ Example: usage of the memory devices 524288 +
@@ -8113,6 +8114,7 @@ Example: usage of the memory devices 2048 1048576 524288 +
@@ -8256,6 +8258,11 @@ Example: usage of the memory devices element is formatted into live XML and never parsed, i.e. it is output-only element. =20 + ``address`` + For ``virtio-mem`` and ``virtio-pmem`` only. + The physical address in memory, where device is mapped. :since:`Since + 9.3.0` + =20 IOMMU devices ~~~~~~~~~~~~~ diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9f49c6e62d..bed6acac3a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13377,6 +13377,7 @@ virDomainMemoryTargetDefParseXML(xmlNodePtr node, virDomainMemoryDef *def) { VIR_XPATH_NODE_AUTORESTORE(ctxt) + xmlNodePtr addrNode =3D NULL; int rv; =20 ctxt->node =3D node; @@ -13422,16 +13423,27 @@ virDomainMemoryTargetDefParseXML(xmlNodePtr node, if (virDomainParseMemory("./requested", "./requested/@unit", ctxt, &def->requestedsize, false, false) < 0) return -1; + + addrNode =3D virXPathNode("./address", ctxt); + break; + + case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM: + addrNode =3D virXPathNode("./address", ctxt); break; =20 case VIR_DOMAIN_MEMORY_MODEL_NONE: case VIR_DOMAIN_MEMORY_MODEL_DIMM: - case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM: case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC: case VIR_DOMAIN_MEMORY_MODEL_LAST: break; } =20 + if (addrNode && + virXMLPropULongLong(addrNode, "base", 16, + VIR_XML_PROP_NONE, &def->address) < 0) { + return -1; + } + return 0; } =20 @@ -20996,6 +21008,13 @@ virDomainMemoryDefCheckABIStability(virDomainMemor= yDef *src, return false; } =20 + if (src->address !=3D dst->address) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target memory device address '0x%llx' doesn't ma= tch source memory device address '0x%llx'"), + dst->address, src->address); + return false; + } + if (src->model =3D=3D VIR_DOMAIN_MEMORY_MODEL_NVDIMM) { if (src->labelsize !=3D dst->labelsize) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -25184,6 +25203,9 @@ virDomainMemoryTargetDefFormat(virBuffer *buf, } } =20 + if (def->address) + virBufferAsprintf(&childBuf, "
\n", def->= address); + virXMLFormatElement(buf, "target", NULL, &childBuf); } =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 5a2c70f012..0a8e877a63 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2646,6 +2646,8 @@ struct _virDomainMemoryDef { unsigned long long currentsize; /* kibibytes, valid for VIRTIO_MEM and active domain only, only to report = never parse */ + unsigned long long address; /* address where memory is mapped, valid f= or + VIRTIO_PMEM and VIRTIO_MEM only. */ bool readonly; /* valid only for NVDIMM */ =20 /* required for QEMU NVDIMM ppc64 support */ diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index f208c0c531..ad76a21ca2 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2358,6 +2358,12 @@ virDomainMemoryDefValidate(const virDomainMemoryDef = *mem, _("requested size must be an integer multiple o= f block size")); return -1; } + + if (mem->address % mem->blocksize !=3D 0) { + virReportError(VIR_ERR_XML_DETAIL, "%s", + _("memory device address must be aligned to blo= cksize")); + return -1; + } break; =20 case VIR_DOMAIN_MEMORY_MODEL_DIMM: diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 6158ed79ac..9af47f9688 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -7153,6 +7153,13 @@ + + + + + + + diff --git a/tests/qemuxml2argvdata/memory-hotplug-virtio-mem.xml b/tests/q= emuxml2argvdata/memory-hotplug-virtio-mem.xml index 73036d8602..f5cc4a35ed 100644 --- a/tests/qemuxml2argvdata/memory-hotplug-virtio-mem.xml +++ b/tests/qemuxml2argvdata/memory-hotplug-virtio-mem.xml @@ -65,6 +65,7 @@ 0 2048 1048576 +
diff --git a/tests/qemuxml2argvdata/memory-hotplug-virtio-pmem.xml b/tests/= qemuxml2argvdata/memory-hotplug-virtio-pmem.xml index 4cebd294ec..21b90e4d8a 100644 --- a/tests/qemuxml2argvdata/memory-hotplug-virtio-pmem.xml +++ b/tests/qemuxml2argvdata/memory-hotplug-virtio-pmem.xml @@ -47,6 +47,7 @@ 524288 +
--=20 2.39.2