From nobody Sun Apr 28 18:16:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1635332535; cv=none; d=zohomail.com; s=zohoarc; b=do90/DyTZrkDeCvPUFw4H++weQST1ZxXy4DHTi5arjr7jqHjV2TwFA9gFmUnbtYJ6ratlJ9At685fe4gcvtCC3wVfsh1YkO84HWbBkH8aHHZc2FExWUAGa8RJf+H58w6ikPPmsm3bDArn/d0POQz0IEfDPnMvejEb5i2Nu3Yz3k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635332535; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=R+4Ot+vK9wnAVuavd4cn2QkpE5Rd9FBXfUak0eVOqMQ=; b=nmnWyrJU2o8DrRjm/CK3ow+Nv6deMnEWUShsRCCwlziwRsGPBnjbDh3Q5LffMXjzWkUAShzn1Oo27A2AUIb0yEQfDo6kvi1scfxiS+Cai9Wo0WWygV5OuDGWgFbyHy1owlYLSGIx5XbnOP2/JPoEjS9xkwLErmO2vxr5L/HMrzg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1635332535314461.0239320705181; Wed, 27 Oct 2021 04:02:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-543-pYMuMxmiPUKxM0bQeI6VbA-1; Wed, 27 Oct 2021 07:02:10 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C68BA806691; Wed, 27 Oct 2021 11:02:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A7C460CA0; Wed, 27 Oct 2021 11:02:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5A164A703; Wed, 27 Oct 2021 11:02:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19RAw3nR002339 for ; Wed, 27 Oct 2021 06:58:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id E989817CD9; Wed, 27 Oct 2021 10:58:03 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7109B1815D for ; Wed, 27 Oct 2021 10:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635332534; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=R+4Ot+vK9wnAVuavd4cn2QkpE5Rd9FBXfUak0eVOqMQ=; b=RBFEvaMAwD3phmv6fAJkYlviPJWinYuEA/YOm1MIeqiaezfD0j1K5hf2eWveFnwHO2acND S5gN4jrwZcMW0du/kmiZbiuXRzDWR+iXc8pZPVK5hT6+YS3R9YnPUt6HhSgKCESliGXqeu 3d49ZwlAXFirgxfLE9DhMdothdpWKag= X-MC-Unique: pYMuMxmiPUKxM0bQeI6VbA-1 From: Kristina Hanicova To: libvir-list@redhat.com Subject: [PATCH v2] qemu_agent: remove unused code Date: Wed, 27 Oct 2021 12:57:55 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1635332536437100001 Content-Type: text/plain; charset="utf-8" This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October= /msg01064.html Diff to v1: * I forgot to delete another part of the unused code which belonged together (noticed by Jano) This section of code was left unused ever since it was introduced ten years ago. I think we can safely remove it. Signed-off-by: Kristina Hanicova --- src/qemu/qemu_agent.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5f421be6f6..f319b881fc 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -60,17 +60,6 @@ VIR_LOG_INIT("qemu.qemu_agent"); */ #define QEMU_AGENT_MAX_RESPONSE (10 * 1024 * 1024) =20 -/* When you are the first to uncomment this, - * don't forget to uncomment the corresponding - * part in qemuAgentIOProcessEvent as well. - * -static struct { - const char *type; - void (*handler)(qemuAgent *agent, virJSONValue *data); -} eventHandlers[] =3D { -}; -*/ - typedef struct _qemuAgentMessage qemuAgentMessage; struct _qemuAgentMessage { char *txBuffer; @@ -237,17 +226,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent, return -1; } =20 -/* - for (i =3D 0; i < G_N_ELEMENTS(eventHandlers); i++) { - if (STREQ(eventHandlers[i].type, type)) { - virJSONValue *data =3D virJSONValueObjectGet(obj, "data"); - VIR_DEBUG("handle %s handler=3D%p data=3D%p", type, - eventHandlers[i].handler, data); - (eventHandlers[i].handler)(agent, data); - break; - } - } -*/ return 0; } =20 --=20 2.31.1