From nobody Sun Feb  8 07:58:03 2026
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28
 as permitted sender) client-ip=209.132.183.28;
 envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com;
Authentication-Results: mx.zohomail.com;
	spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
Return-Path: <libvir-list-bounces@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
 mx.zohomail.com
	with SMTPS id 155191546585240.60557679732983;
 Wed, 6 Mar 2019 15:37:45 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 311DD804F2;
	Wed,  6 Mar 2019 23:37:44 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 118411902F;
	Wed,  6 Mar 2019 23:37:44 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id C240B181A266;
	Wed,  6 Mar 2019 23:37:43 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
	[10.5.11.22])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id x26NbKot005208 for <libvir-list@listman.util.phx.redhat.com>;
	Wed, 6 Mar 2019 18:37:20 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 23D3C1001E64; Wed,  6 Mar 2019 23:37:20 +0000 (UTC)
Received: from worklaptop.redhat.com (ovpn-121-104.rdu2.redhat.com
	[10.10.121.104])
	by smtp.corp.redhat.com (Postfix) with ESMTP id B4DF41001E61;
	Wed,  6 Mar 2019 23:37:19 +0000 (UTC)
From: Cole Robinson <crobinso@redhat.com>
To: libvirt-list@redhat.com
Date: Wed,  6 Mar 2019 18:36:57 -0500
Message-Id: 
 <bd37965106705bdda71cfcca29ed40802b380013.1551914794.git.crobinso@redhat.com>
In-Reply-To: <cover.1551914794.git.crobinso@redhat.com>
References: <cover.1551914794.git.crobinso@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v2 08/16] bhyve: domcaps: fill in explicit
	supported BOOL_NO
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	<libvir-list.redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/libvir-list>,
	<mailto:libvir-list-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/libvir-list>
List-Post: <mailto:libvir-list@redhat.com>
List-Help: <mailto:libvir-list-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/libvir-list>,
	<mailto:libvir-list-request@redhat.com?subject=subscribe>
Content-Transfer-Encoding: quoted-printable
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted,
 not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]);
 Wed, 06 Mar 2019 23:37:44 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"

<hostdev> and <features> are not supported. <loader>, <graphics>,
and <video> are supported conditionally

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/bhyve/bhyve_capabilities.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
index 79d7659da3..ff78023895 100644
--- a/src/bhyve/bhyve_capabilities.c
+++ b/src/bhyve/bhyve_capabilities.c
@@ -86,6 +86,7 @@ virBhyveDomainCapsFill(virDomainCapsPtr caps,
=20
     caps->os.supported =3D VIR_TRISTATE_BOOL_YES;
=20
+    caps->os.loader.supported =3D VIR_TRISTATE_BOOL_NO;
     if (bhyvecaps & BHYVE_CAP_LPC_BOOTROM) {
         caps->os.loader.supported =3D VIR_TRISTATE_BOOL_YES;
         VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.type,
@@ -98,12 +99,21 @@ virBhyveDomainCapsFill(virDomainCapsPtr caps,
     }
=20
=20
+    caps->graphics.supported =3D VIR_TRISTATE_BOOL_NO;
+    caps->video.supported =3D VIR_TRISTATE_BOOL_NO;
     if (bhyvecaps & BHYVE_CAP_FBUF) {
         caps->graphics.supported =3D VIR_TRISTATE_BOOL_YES;
         caps->video.supported =3D VIR_TRISTATE_BOOL_YES;
         VIR_DOMAIN_CAPS_ENUM_SET(caps->graphics.type, VIR_DOMAIN_GRAPHICS_=
TYPE_VNC);
         VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_T=
YPE_GOP);
     }
+
+    caps->hostdev.supported =3D VIR_TRISTATE_BOOL_NO;
+    caps->iothreads =3D VIR_TRISTATE_BOOL_NO;
+    caps->vmcoreinfo =3D VIR_TRISTATE_BOOL_NO;
+    caps->genid =3D VIR_TRISTATE_BOOL_NO;
+    caps->gic.supported =3D VIR_TRISTATE_BOOL_NO;
+
     return 0;
 }
=20
--=20
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list