From nobody Sun Feb 8 18:10:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639583717; cv=none; d=zohomail.com; s=zohoarc; b=Zbvp6axV7p2/kzkJwEFEORCIsPdTOQce/ugc4h3TQWrGZy32yBz9WgnkAm/SrsXtmmEsCG48dwzVewj1K5srFOJVpK4YEMisVXctAhc7UIydGtuLSxrBf/QYeyn8n6cOCIpiIFuBOf51yjHAmb+//xf0LQn9LDhu4uS1dVt/I2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639583717; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dM0Ik4Ih/nwriOXOSNZDLnl90nVh/l/JIDZZ+vjjOCY=; b=m1R+/O3mC/ROhLs4FoNcqUdjWqI6vAvIVJ7hyE8kjR3bPXSkupYmx9b1JiX4XS9mb/zqTqJKH+jOvuhhFl5J+K99QYAaaPXppPX11cyClWVjNeyRCdn1IHR47EpwvnczXfT84q5yECXF++DgU2q7satmmeH8jtD4GCAWgnC4MOs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1639583717832526.4931929478442; Wed, 15 Dec 2021 07:55:17 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-47-Fhs1Y2SnM7iPHmyHMU3pGg-1; Wed, 15 Dec 2021 10:54:21 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8AFAF1006AAD; Wed, 15 Dec 2021 15:54:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C05A60CC9; Wed, 15 Dec 2021 15:54:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3EBEE1809CBF; Wed, 15 Dec 2021 15:54:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BFFqtMb009308 for ; Wed, 15 Dec 2021 10:52:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id 44550610AE; Wed, 15 Dec 2021 15:52:55 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.34.247.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DC64610A7 for ; Wed, 15 Dec 2021 15:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639583716; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dM0Ik4Ih/nwriOXOSNZDLnl90nVh/l/JIDZZ+vjjOCY=; b=Pk1EwWACWR1vThrAEL24lB7PlA3TYFMxvi206aYYQYgOVnSYvg5U0Fr4II2dJoyefBDVDO hyUJjAA4KGDW0+8vo7Dwt+JzaZPDrGoOGekKw8PLsdS9qAeQDwwhTPWakrAIhONdpqeitv rxGuuzOcyxTh1CPNngZYphJye1iqqNQ= X-MC-Unique: Fhs1Y2SnM7iPHmyHMU3pGg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/3] qemu_command: do use host-nodes for system memory Date: Wed, 15 Dec 2021 16:52:14 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639583719198100001 Content-Type: text/plain; charset="utf-8" After previous commit, it's no longer possible to change nodeset for strict numatune. Therefore, we can start generating host-nodes onto command line again. This partially reverts d73265af6ec41104c20633b5c0a23688a62105e6. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 3 +-- .../qemuxml2argvdata/numatune-system-memory.x86_64-latest.args | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6d00105b24..b554f4f025 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3906,8 +3906,7 @@ qemuBuildMemoryBackendProps(virJSONValue **backendPro= ps, /* If mode is "restrictive", we should only use cgroups setting allowe= d memory * nodes, and skip passing the host-nodes and policy parameters to QEM= U command * line which means we will use system default memory policy. */ - if (!systemMemory && nodemask && - mode !=3D VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE) { + if (nodemask && mode !=3D VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE) { if (!virNumaNodesetIsAvailable(nodemask)) return -1; if (virJSONValueObjectAdd(&props, diff --git a/tests/qemuxml2argvdata/numatune-system-memory.x86_64-latest.ar= gs b/tests/qemuxml2argvdata/numatune-system-memory.x86_64-latest.args index 2c1180b77e..fd93abe3eb 100644 --- a/tests/qemuxml2argvdata/numatune-system-memory.x86_64-latest.args +++ b/tests/qemuxml2argvdata/numatune-system-memory.x86_64-latest.args @@ -14,7 +14,7 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \ -accel tcg \ -cpu qemu64 \ -m 214 \ --object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264,"= host-nodes":[0],"policy":"bind"}' \ -overcommit mem-lock=3Doff \ -smp 2,sockets=3D2,cores=3D1,threads=3D1 \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --=20 2.32.0