From nobody Sun Feb 8 18:43:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555598604; cv=none; d=zoho.com; s=zohoarc; b=hsIHHJLcFbhz0qseFfj7mofyT3NPqtKezVQfbTqE+/Vztue3IAY7lgB+Km5W0xcVzAPot+ihxCqTM4XCaiesxyRKxK3gYF1qkS4fz+odiwiV9YGoQvNcjZPsWQc80Yf9Gpg9kl5EGkT4ctoXkHvPW8wLGt5YW7/AXbuKVZs8oXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555598604; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=XyI/jSC1gsROYeSkQO7rSl5BPesJleOrPcN5tyKVe54=; b=KeYk1zS3H2DKKdnduSABWeGcua4MAtMTvbhz716L6zY/Y/XiWBuWXxv7scEi47BAkmF7YCza8v5hGQml9ud/DgA7NIlULpRQWbondP/3iiixqC5YP3ertMAbC+v4tViVS6qyZ34i4toKZu9FMpUyHYMjBEg3tkb+PYYBNK46Jg8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1555598604887771.3866644866218; Thu, 18 Apr 2019 07:43:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C17B88AB1; Thu, 18 Apr 2019 14:43:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1898A600C5; Thu, 18 Apr 2019 14:43:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B0C71181AC8E; Thu, 18 Apr 2019 14:43:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3IEhGsA020788 for ; Thu, 18 Apr 2019 10:43:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 61E6E60BFC; Thu, 18 Apr 2019 14:43:16 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE78E60BEC for ; Thu, 18 Apr 2019 14:43:15 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Thu, 18 Apr 2019 16:43:02 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 07/12] qemu: Refactor/simplify qemuDomainStorageSourceAccessRevoke X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 18 Apr 2019 14:43:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Use qemuDomainStorageSourceAccessModify instead of the individual calls. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_domain.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 30acba3c47..f7d1250f09 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9332,18 +9332,9 @@ qemuDomainStorageSourceAccessRevoke(virQEMUDriverPtr= driver, virDomainObjPtr vm, virStorageSourcePtr elem) { - if (qemuTeardownImageCgroup(vm, elem) < 0) - VIR_WARN("Failed to teardown cgroup for disk path %s", - NULLSTR(elem->path)); + qemuDomainStorageSourceAccessFlags flags =3D QEMU_DOMAIN_STORAGE_SOURC= E_ACCESS_REVOKE; - if (qemuSecurityRestoreImageLabel(driver, vm, elem, false) < 0) - VIR_WARN("Unable to restore security label on %s", NULLSTR(elem->p= ath)); - - if (qemuDomainNamespaceTeardownDisk(vm, elem) < 0) - VIR_WARN("Unable to remove /dev entry for %s", NULLSTR(elem->path)= ); - - if (virDomainLockImageDetach(driver->lockManager, vm, elem) < 0) - VIR_WARN("Unable to release lock on %s", NULLSTR(elem->path)); + ignore_value(qemuDomainStorageSourceAccessModify(driver, vm, elem, fla= gs)); } --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list