From nobody Sun Feb 8 16:12:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642516715; cv=none; d=zohomail.com; s=zohoarc; b=QvBY/JgbIKUNp2oYgAzTgwdSK/Rsrln3X7BQh7cpt7xwqIJUUp2XO2rX1/3RVyHV8+f++m/K/V5k3Pk2GWiO3M/P191sHFWqJWUuN+5f4IbnT8JyukZrXhKeGYgzSJpZoe5zwfGH/BwJodJuZz6ah2Z9d3QSSskI8uANuXMbm2U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642516715; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UPC+7fuFSJv4tIKCapoFLX2lh+S5a6RvFIrfIMb8gMI=; b=eM+stcKIvQ0AGTx2XFGvp+/xA4vUqFQzQiDDNZ14LWhAMjvYyAx0L89yIzoqgWNjV39JaIWcU3nNy5HhgivR4psYwO8gusGWbl+6OUL1yFGhFdL+LcGcl5ZSIAbtRmy9P/YonwNMTTFXGgcScIEOg2Bpz9yOGIFa9Z2/3VS8isM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642516715226172.1279492778391; Tue, 18 Jan 2022 06:38:35 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-308-uCQKAEm8ORm72wpZ60CULA-1; Tue, 18 Jan 2022 09:38:30 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F37683DD2C; Tue, 18 Jan 2022 14:38:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B8027E12C; Tue, 18 Jan 2022 14:38:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F184B1809CBF; Tue, 18 Jan 2022 14:38:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20IEbfRN016636 for ; Tue, 18 Jan 2022 09:37:42 -0500 Received: by smtp.corp.redhat.com (Postfix) id EFBC82BE7F; Tue, 18 Jan 2022 14:37:41 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 798392C1B4 for ; Tue, 18 Jan 2022 14:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642516714; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UPC+7fuFSJv4tIKCapoFLX2lh+S5a6RvFIrfIMb8gMI=; b=G10NiWwJt35kpLzaT1/CwD0scoratrGKFTaA0FWNw0XP2ckyOBFKUnbeGL0Y+NwQw3NwcJ MwILZhqXRHP9vY0k6AqVFO7z9IRTaTf5emOGdj8Th6hk2PFj5I79BZ11nGbIv5VUujuMcb CuBiOwNk0VKYHtXSNxoYqg835vGwIfQ= X-MC-Unique: uCQKAEm8ORm72wpZ60CULA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v5 03/13] virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() Date: Tue, 18 Jan 2022 15:37:10 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642516716341100001 Content-Type: text/plain; charset="utf-8" This argument is not used really as the only caller passes true and dnsmasqCapsRefreshInternal() only checks for false value. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- src/util/virdnsmasq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 9f3da1d5e6..7fcaadda3f 100644 --- a/src/util/virdnsmasq.c +++ b/src/util/virdnsmasq.c @@ -649,7 +649,7 @@ dnsmasqCapsSetFromBuffer(dnsmasqCaps *caps, const char = *buf) } =20 static int -dnsmasqCapsRefreshInternal(dnsmasqCaps *caps, bool force) +dnsmasqCapsRefreshInternal(dnsmasqCaps *caps) { struct stat sb; g_autoptr(virCommand) vercmd =3D NULL; @@ -666,7 +666,7 @@ dnsmasqCapsRefreshInternal(dnsmasqCaps *caps, bool forc= e) caps->binaryPath); return -1; } - if (!force && caps->mtime =3D=3D sb.st_mtime) + if (caps->mtime =3D=3D sb.st_mtime) return 0; caps->mtime =3D sb.st_mtime; =20 @@ -734,7 +734,7 @@ dnsmasqCapsNewFromBinary(void) if (!caps) return NULL; =20 - if (dnsmasqCapsRefreshInternal(caps, true) < 0) + if (dnsmasqCapsRefreshInternal(caps) < 0) return NULL; =20 return g_steal_pointer(&caps); --=20 2.34.1