From nobody Tue Sep 22 06:40:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784735028; cv=none; d=zohomail.com; s=zohoarc; b=PRJWLuQg8M+SPX4+VGoKaSAu1hlWL+TXSSyclAk81LOFLOTOa65dq4HLOJLOiWfTABZ2i3AYSnEiCqFFkj9lGxcD0T4wUW/JIDYZJ18kddefT4KaU/mXwKLdXiTbNv36lwoV9K/Hy9DApzzK822PjtdWQ1mxV/29/wJN8mmQv4I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784735028; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=SlDc4mvk1KYquaHMRqjVdkSZ2ZgcRpx3IyI4maTNFSE=; b=NQSouEI98a4hHJGBNTyIkenAX0jUhKpViYik6+l7d9zmMvtX6wSQOrzH7213z1bZvtyHUpNyXl61eBZ5aXwCSkf1oKDolkqaJbw+rVd4Lt8c11ZmwEpVfjypBWtwR7T4oB4kpB+tUC/MgBEBtx7QPBgeJADEhbwufVNE8IIZ3uI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784735028313295.83897059559763; Wed, 22 Jul 2026 08:43:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 19ADF41B69; Wed, 22 Jul 2026 11:43:47 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id CCAE241E77; Wed, 22 Jul 2026 11:38:46 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 37A3D41920; Wed, 22 Jul 2026 11:38:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6B6DE4190D for ; Wed, 22 Jul 2026 11:38:26 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-cxZRsOEoNxq0sb1LVd8zpg-1; Wed, 22 Jul 2026 11:38:24 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 858E51800772 for ; Wed, 22 Jul 2026 15:38:23 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D0AD5D70 for ; Wed, 22 Jul 2026 15:38:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784734706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlDc4mvk1KYquaHMRqjVdkSZ2ZgcRpx3IyI4maTNFSE=; b=AMV7pzWfx5XQeo9poTplzkI27aOhX6se5DjN+R2co3Eqc1eC/YUOVCDk6Yqhs4kFolvwpi PVk17B7WBCvCLTzkznzeUPrQCLjhu62RmeQEIhCmtqpH3CDJMFh+197yGhBg2/Ad9UdLqe 1VVo4qbWNxrnPxMvtMjoofsG5YzSfoc= X-MC-Unique: cxZRsOEoNxq0sb1LVd8zpg-1 X-Mimecast-MFC-AGG-ID: cxZRsOEoNxq0sb1LVd8zpg_1784734703 To: devel@lists.libvirt.org Subject: [PATCH 02/13] qemu: Remove unused 'qemuProcessRebootAllowed' Date: Wed, 22 Jul 2026 17:38:07 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mPKdDo1yr65yIVuF_D9kNthdbGfuhDIDPH8ovqrnLXA_1784734703 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ORHOCXUCXEX4ISXDUZ66CR7TAUUXLQII X-Message-ID-Hash: ORHOCXUCXEX4ISXDUZ66CR7TAUUXLQII X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784735030483158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_process.c | 18 ------------------ src/qemu/qemu_process.h | 2 -- 2 files changed, 20 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 646ddda7e9..a1cdce6d17 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6880,24 +6880,6 @@ qemuProcessPrepareDomainHostdevs(virDomainObj *vm, } -/** - * qemuProcessRebootAllowed: - * @def: domain definition - * - * This function encapsulates the logic which dictated whether '-no-reboot= ' was - * used instead of '-no-shutdown' which is used QEMU versions which don't - * support the 'set-action' QMP command. - */ -bool -qemuProcessRebootAllowed(const virDomainDef *def) -{ - return def->onReboot !=3D VIR_DOMAIN_LIFECYCLE_ACTION_DESTROY || - def->onPoweroff !=3D VIR_DOMAIN_LIFECYCLE_ACTION_DESTROY || - (def->onCrash !=3D VIR_DOMAIN_LIFECYCLE_ACTION_DESTROY && - def->onCrash !=3D VIR_DOMAIN_LIFECYCLE_ACTION_COREDUMP_DESTROY= ); -} - - static int qemuProcessUpdateSEVInfo(virDomainObj *vm) { diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 5874214596..2db5186e08 100644 --- a/src/qemu/qemu_process.h +++ b/src/qemu/qemu_process.h @@ -258,8 +258,6 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(qemuProcessQMP, qemuProce= ssQMPFree); int qemuProcessQMPStart(qemuProcessQMP *proc); -bool qemuProcessRebootAllowed(const virDomainDef *def); - void qemuProcessCleanupMigrationJob(virQEMUDriver *driver, virDomainObj *vm); --=20 2.55.0