From nobody Sun Feb 8 09:22:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585316770; cv=none; d=zohomail.com; s=zohoarc; b=gC9jTgxoU6QhGluz1Iqoax0eJKa3ANUYkIPiie8KGDMZpSo19Gmc23Z75vuFpgVe3Tsm8swZC95kO6ru9bHJjVG2inEN4HW/0jsM/16vtLfSiGqonRCAnhemoK8wJ0U/4IQ7hnVEdddsTR6qvOogTOXaMsx/Ecgt5GIAxmYcqJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585316770; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ejifzhw4CSpy9tagqkzyIy9831Ak8x6hJPofPrT/gM4=; b=JKlSq2XcQLMsjykUZNFrhIAFhnsOhisokrWXB603FP+r2a9ZvOnlXdYtkHhlL4GYHQGEtnwiF1tkWXU7o2rAsoBXgnX5zc1FoFCfgScu8mlDALrezmncQOSJEk+VixxqXxVMcTmqGN0K40HrusSAgdwpYU64V1jZeZNjVHvV8fQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1585316770048428.16229793231344; Fri, 27 Mar 2020 06:46:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-Ga99MlbLO9C5t5hgXKX9zA-1; Fri, 27 Mar 2020 09:46:06 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DAFE1800D50; Fri, 27 Mar 2020 13:45:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B03245E01E; Fri, 27 Mar 2020 13:45:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6ECE21819AD1; Fri, 27 Mar 2020 13:45:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02RDiQke006468 for ; Fri, 27 Mar 2020 09:44:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0E9815DA7D; Fri, 27 Mar 2020 13:44:26 +0000 (UTC) Received: from rein.int.mamuti.net (unknown [10.40.192.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D52225DA75 for ; Fri, 27 Mar 2020 13:44:24 +0000 (UTC) Received: by rein.int.mamuti.net (Postfix, from userid 500) id 24FA018F8BC; Fri, 27 Mar 2020 14:44:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585316768; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ejifzhw4CSpy9tagqkzyIy9831Ak8x6hJPofPrT/gM4=; b=eLzCGXBAaBRG53RcS8Tu9kVhQl0F1MFxsgp5xP7mnGQj3TCfiQ2Cszp/AYe+6fhcaoJipf uVUoopSSPcbKQu8hcJRgLlLyBjCLoT4rdt8xAIzerbo0M8pJWDC8La9OerZ0dT/1n3CO0N sit9FyuPQv1iMr/MfMwHQktBRR7L0U4= X-MC-Unique: Ga99MlbLO9C5t5hgXKX9zA-1 From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH 31/39] cpu_x86: Move and rename x86FormatSignatures Date: Fri, 27 Mar 2020 14:44:00 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Later in this series the function will work on a newly introduced virCPUx86Signatures structure. Let's move it to the place were all related functions will be added and rename the function as virCPUx86SignaturesFormat for easier review of the virCPUx86Signatures patch. Signed-off-by: Jiri Denemark Reviewed-by: J=C3=A1n Tomko --- src/cpu/cpu_x86.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index ff44cae77e..182d0da97c 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1125,6 +1125,23 @@ virCPUx86SignaturesMatch(virCPUx86ModelPtr model, } =20 =20 +static char * +virCPUx86SignaturesFormat(virCPUx86ModelPtr model) +{ + virBuffer buf =3D VIR_BUFFER_INITIALIZER; + size_t i; + + for (i =3D 0; i < model->nsignatures; i++) { + virBufferAsprintf(&buf, "%06lx,", + (unsigned long)model->signatures[i]); + } + + virBufferTrim(&buf, ","); + + return virBufferContentAndReset(&buf); +} + + static void x86ModelFree(virCPUx86ModelPtr model) { @@ -1892,23 +1909,6 @@ virCPUx86Compare(virCPUDefPtr host, } =20 =20 -static char * -x86FormatSignatures(virCPUx86ModelPtr model) -{ - virBuffer buf =3D VIR_BUFFER_INITIALIZER; - size_t i; - - for (i =3D 0; i < model->nsignatures; i++) { - virBufferAsprintf(&buf, "%06lx,", - (unsigned long)model->signatures[i]); - } - - virBufferTrim(&buf, ","); - - return virBufferContentAndReset(&buf); -} - - /* * Checks whether a candidate model is a better fit for the CPU data than = the * current model. @@ -2138,7 +2138,7 @@ x86Decode(virCPUDefPtr cpu, if (vendor) cpu->vendor =3D g_strdup(vendor->name); =20 - sigs =3D x86FormatSignatures(model); + sigs =3D virCPUx86SignaturesFormat(model); =20 VIR_DEBUG("Using CPU model %s (signatures %s) for CPU with signature %= 06lx", model->name, NULLSTR(sigs), (unsigned long)signature); --=20 2.26.0