From nobody Mon Feb 9 01:22:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613410092; cv=none; d=zohomail.com; s=zohoarc; b=DfeasF3x8NVHoqFIYQ+WLwRttAJz4XB20DAOK0GQGpOKsmPnQXNGXszAEJLrCJjH1JnEOEwbQDjtcvqjVf2q3DhyhKuSTg4qWnfufD0nbIxsYjmjAk6dWbfhRTqQwAAtGOxUEraWm3OxCIKyOEtQ0P5OW5B7ewNJwC/0nVX0FaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613410092; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tDZqKka5TMXEd94uxx8Llys9N8O+SECDDLEpUUcrenM=; b=gg44WWL5FaCZ+fnkGEixnwFpV1UmhKqKiAqNBGNE5kDnfIuep5F40h87BDpfKiGeGKuit1cT0hdK0ok/6BKEXAtFVJ9mUtUWPLZOFsGiTdaQeWgtBZ1KKqyIBEQRlzPdu2I6z+rGZYM4sqMnnJNwY0a/JZDz66zJmDdJ/ss604c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1613410092582998.247006538737; Mon, 15 Feb 2021 09:28:12 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-ZYf48WUVPu2pK2ASpxDz6A-1; Mon, 15 Feb 2021 12:28:09 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC6EBEC1A0; Mon, 15 Feb 2021 17:28:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C49CF62463; Mon, 15 Feb 2021 17:28:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 851399991; Mon, 15 Feb 2021 17:28:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 11FHS0ZZ001373 for ; Mon, 15 Feb 2021 12:28:00 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5C36F1B534; Mon, 15 Feb 2021 17:28:00 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id B45D55C241 for ; Mon, 15 Feb 2021 17:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613410091; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tDZqKka5TMXEd94uxx8Llys9N8O+SECDDLEpUUcrenM=; b=GIBYLB+FBDNh6x0YjuoCqiniR8hopPOM38rsq2AoVi/xN3nGzjIFIOrGq6VBi95e3kB72f 6VM7rOsazMefZ38DjhKWTLhR5TsT1J4uF4+eu1E26gvNbjylp7WCe6hKob+wXh0qv6Rhft KWmHGflB/bloql/uRNFpgqLmxtAU48c= X-MC-Unique: ZYf48WUVPu2pK2ASpxDz6A-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2 Date: Mon, 15 Feb 2021 18:27:51 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The -2 value is misleading because if 'qemuAgentFSFreeze' fails it doesn't necessarily mean that the command was sent to the agent. Since callers don't care about the -2 value specifically, remove it. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index eacc8c6400..93b74b035a 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -119,9 +119,6 @@ qemuSnapshotCountExternal(void *payload, } -/* Return -1 if request is not sent to agent due to misconfig, -2 if reque= st - * is sent but failed, and number of frozen filesystems on success. If -2 = is - * returned, FSThaw should be called revert the quiesced status. */ int qemuSnapshotFSFreeze(virDomainObjPtr vm, const char **mountpoints, @@ -136,7 +133,7 @@ qemuSnapshotFSFreeze(virDomainObjPtr vm, agent =3D qemuDomainObjEnterAgent(vm); frozen =3D qemuAgentFSFreeze(agent, mountpoints, nmountpoints); qemuDomainObjExitAgent(vm, agent); - return frozen < 0 ? -2 : frozen; + return frozen; } --=20 2.29.2