From nobody Mon Feb 9 10:29:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617285276; cv=none; d=zohomail.com; s=zohoarc; b=PV+yGfHovU3iWFdmIoUuQQ6PZScUtB+Pv1Vv12aPdGd2A0UAd857dEMUYk/m46YCJFVJ6fNHYDYrRDRJleBh4bFHYO1c7Ucq8HfFRDIxqSzc/MngB1i8/j3coc27vU/j0bNiPiB6mBI3TF2a2/G+g98UaN2bAheC9Kro+AJjNZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617285276; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ULWtbOeYLZAfGnuBM0O5ZL3V3pxbt5tIrd6rZLv9LB4=; b=FARaQw9Y3JOijiAVr8SDnakz2WCO+mXpoG85qVssjys1Lwoeo2u9D3uiYpjsFiUD3YTlfpS9Xs9oYlWshTe9GLONhP3uik7rJ0CZ2qooZtN/x2cHGe7ustAGUxPktk73bMBcjA7xFVTvt4HdJvn6LRfXqaMq5tBbKH65eAIgcH4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617285276557398.69626399017204; Thu, 1 Apr 2021 06:54:36 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-SsgtmyfOPoyXExBv15vr5w-1; Thu, 01 Apr 2021 09:54:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA58319251BB; Thu, 1 Apr 2021 13:54:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9E78804E7; Thu, 1 Apr 2021 13:54:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7907C1802138; Thu, 1 Apr 2021 13:54:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131Ds5dD023388 for ; Thu, 1 Apr 2021 09:54:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id D7C065C239; Thu, 1 Apr 2021 13:54:05 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17CE75C701 for ; Thu, 1 Apr 2021 13:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617285275; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ULWtbOeYLZAfGnuBM0O5ZL3V3pxbt5tIrd6rZLv9LB4=; b=iJQK472kWGLqJhd/wne15lRMM0WK5jx4+sBIUMqwrFi6L9FGZnnRE0XOkKb8FgkDB65r5I SwLefTU/Ecq0RcXA8ks43NkBXeSEG15zBl4UUX8KPjkHLCMb9V6PQkZJKMF8hCQ2Vf2eEM jMBgfbz0tyd0i9JUpkOnIEFoZy/Kq/8= X-MC-Unique: SsgtmyfOPoyXExBv15vr5w-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 21/39] virshParseRateStr: Use g_strsplit instead of virStringSplitCount Date: Thu, 1 Apr 2021 15:52:20 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Count the elements after splitting the string. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 37be298809..532169d8d7 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -860,10 +860,10 @@ virshParseRateStr(vshControl *ctl, g_auto(GStrv) tok =3D NULL; size_t ntok; - if (!(tok =3D virStringSplitCount(rateStr, ",", 0, &ntok))) + if (!(tok =3D g_strsplit(rateStr, ",", 0))) return -1; - if (ntok > 4) { + if ((ntok =3D g_strv_length(tok)) > 4) { vshError(ctl, _("Rate string '%s' has too many fields"), rateStr); return -1; } --=20 2.29.2