From nobody Sun Feb 8 19:25:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607094545; cv=none; d=zohomail.com; s=zohoarc; b=mpkYBMRBfyYXbmLYwIrVFnbntlJJpSnhs4zFni4K6mkTV17tA4eyJWtxr1ewzaQBAIzSI+p9aHVe9THFStEgnlbRJ6ntbpLykswKu8alwx7qZqh29sW2x33lHSqQawnq1EEq1/ahhwF4UgLMM96Fq0bTO0CSAlCZJ7hvMz8AFwE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607094545; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xtHpEz897l8O7KGNkMxgPguZ9vy7ZmR9onKlbJcK6lI=; b=c8t/94QW3T6ogregTv9bVxWLEl4Yxv3Z2Lqjcix7q1AGBdmeRibPnAcIp+WZEJ7JeygH1reDvD+OhbvaRN0wSiuI+jhtFmZ54p6jVip1Gmle6i2scf4Bw1LTiHP04TAB2GE7KRsiCL9Jt3q1FkC8dQkwtQCiN9k4AZAj9LBHG3A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1607094545607738.9455779187003; Fri, 4 Dec 2020 07:09:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-SzHbOofaM-WK8kNyqpTJEA-1; Fri, 04 Dec 2020 10:08:19 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CBCE100F346; Fri, 4 Dec 2020 15:08:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7539A60C64; Fri, 4 Dec 2020 15:08:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CB5751809CA0; Fri, 4 Dec 2020 15:08:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B4F8ASj031257 for ; Fri, 4 Dec 2020 10:08:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9071B5D9D7; Fri, 4 Dec 2020 15:08:10 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id D66B55D9CA for ; Fri, 4 Dec 2020 15:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607094543; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xtHpEz897l8O7KGNkMxgPguZ9vy7ZmR9onKlbJcK6lI=; b=b5DYt2Pp0VZ8YJ3HK6m4UwvUOMo9Bcr8VtGiiobLq3cH/OXwlx0AMAmK40MHIJK3ATCWXT mQBa/7p6Lmn41RVqaif+ZO5CGNBwrfvvBeqBr+G0ah0TLDNikbLNKUvsbbsoRATN5VbnI5 FfBDnmPmFvk4HD3+jlaPkxfyuiVAi2s= X-MC-Unique: SzHbOofaM-WK8kNyqpTJEA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/7] virDomainGetBlockJobInfo: Reword docs for fallback values Date: Fri, 4 Dec 2020 16:07:57 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Explicitly state that if 'end =3D=3D 1' the data doesn't represent actual progress in most cases. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 5d3747fd39..5edc73ecad 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -9940,12 +9940,18 @@ virDomainBlockJobAbort(virDomainPtr dom, const char= *disk, * can be found by calling virDomainGetXMLDesc() and inspecting * elements within //domain/devices/disk. * - * As a corner case underlying hypervisor may report cur =3D=3D 0 and - * end =3D=3D 0 when the block job hasn't been started yet. In this - * case libvirt reports cur =3D 0 and end =3D 1. However, hypervisor - * may return cur =3D=3D 0 and end =3D=3D 0 if the block job has finished - * and was no-op. In this case libvirt reports cur =3D 1 and end =3D 1. - * Since 2.3.0. + * In cases when libvirt can't determine actual progress of the block job = from + * the underlying hypervisor due to corner cases such as the job wasn't yet + * fully initialized, or finalized and thus the progress can't be queried, + * libvirt reports 'cur =3D 0, end =3D 1'. + * + * For jobs requiring finalizing via qemuDomainBlockJobAbort() with + * VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT flag which reached synchronised phase,= but + * were empty, or the progress can't be determined libvirt returns + * 'cur =3D 1, end =3D 1'. + * + * Users thus should not consider any data where 'end =3D 1' as absolute p= rogress + * value. * * Applications looking for a reliable and low-overhead way to determine w= hether * a block job already finished or reached synchronised phase should regis= ter a --=20 2.28.0