From nobody Fri May 3 10:55:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598967047; cv=none; d=zohomail.com; s=zohoarc; b=bV7BCufM4d0GT8qwsJkWubuZURharIhCmNSzvOhLCai2l4EVaQMkiC/4ZVsI99HwKecmuuivgTcF/6JQdNZDTxYi5VQAOZisYzX/eYkSF+R1PmooJHbsxKJsUgFPv1kBFDaycuYzAShSEkvByDQ2c8K7Dzy/aV/Gb9+YDB+NNy4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598967047; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=oAhGvgxNzzZJ5CW+v56wFmbWUAbRE7r5S/TS6FkaPDg=; b=kJLfh8RHuQmqRdGvDjZzV1i0LRtbMlYeYavIpq+sM0Q5VzG9x2JgztFssw163xcOUNzlQK/SiA0Z/mEotIX7M3AH/YSqdQUuXQ7Z/SnaIO759F3Iq78Br9XQIr2SUTI7JRIp9l8lAMJB6rpuVYblQnm4E/bgG5WUY7ZI2wSNOwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1598967047934339.96242142143944; Tue, 1 Sep 2020 06:30:47 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-gOhjj7vbN62H9ZnafzyLSA-1; Tue, 01 Sep 2020 09:30:44 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA2EC802EA5; Tue, 1 Sep 2020 13:30:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F4155D9DC; Tue, 1 Sep 2020 13:30:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AD06E18095FF; Tue, 1 Sep 2020 13:30:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 081DUPVT009489 for ; Tue, 1 Sep 2020 09:30:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id B5633747B0; Tue, 1 Sep 2020 13:30:25 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.194.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 325FF78B53 for ; Tue, 1 Sep 2020 13:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598967047; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oAhGvgxNzzZJ5CW+v56wFmbWUAbRE7r5S/TS6FkaPDg=; b=ZmAwiUEdTCI9E8HfgNeohTtV4+TSukyZKlcgDzAb1Dozo6pTtRC+BF3WvcvDDEVw8cgiEW Io4HRSG5IGhuF5lGfI4njnmkPGMnQI1rRXiekfxABje2sMklvCP50L2Z1leJX69KBxWbQK YLVoZ4nZmDcpkVf7gOGu4HKuq8bhm7s= X-MC-Unique: gOhjj7vbN62H9ZnafzyLSA-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH] meson: add -Wformat explicitly Date: Tue, 1 Sep 2020 15:30:21 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" If someone runs `meson setup --buildtype plain` meson ignores warning_level=3D2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype set to plain. There is an issue reported [1] to not ignore warning_level silently and the change to ignore it was done by upstream commit [2]. [1] [2] Signed-off-by: Pavel Hrdina Reviewed-by: Michal Privoznik --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index e193166a9b..4e99b5ba39 100644 --- a/meson.build +++ b/meson.build @@ -257,6 +257,7 @@ cc_flags +=3D [ '-Wempty-body', '-Wendif-labels', '-Wexpansion-to-defined', + '-Wformat', '-Wformat-contains-nul', '-Wformat-extra-args', '-Wformat-nonliteral', --=20 2.26.2