From nobody Sun Feb 8 17:03:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1554206309702766.2330245895363; Tue, 2 Apr 2019 04:58:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A33AD308793F; Tue, 2 Apr 2019 11:58:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AF93103BAAD; Tue, 2 Apr 2019 11:58:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D3A511803389; Tue, 2 Apr 2019 11:58:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x32ButS4032294 for ; Tue, 2 Apr 2019 07:56:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id B153B60857; Tue, 2 Apr 2019 11:56:55 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3ACEB60856 for ; Tue, 2 Apr 2019 11:56:55 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Tue, 2 Apr 2019 13:56:45 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/5] qemu: domain: drop qemuDomainSupportsBlockJobs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 02 Apr 2019 11:58:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" It always returns true. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 14 -------------- src/qemu/qemu_domain.h | 2 -- src/qemu/qemu_driver.c | 12 ------------ 3 files changed, 28 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2de726247d..0cc6658150 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9900,20 +9900,6 @@ qemuDomainGetMonitor(virDomainObjPtr vm) } -/** - * qemuDomainSupportsBlockJobs: - * @vm: domain object - * - * Returns -1 in case when qemu does not support block jobs at all. Otherw= ise - * returns 0. - */ -int -qemuDomainSupportsBlockJobs(virDomainObjPtr vm ATTRIBUTE_UNUSED) -{ - return 0; -} - - /** * qemuFindAgentConfig: * @def: domain definition diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 00b497e6a6..742632f6de 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -821,8 +821,6 @@ int qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobI= nfo, ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int qemuDomainSupportsBlockJobs(virDomainObjPtr vm) - ATTRIBUTE_NONNULL(1); bool qemuDomainDiskBlockJobIsActive(virDomainDiskDefPtr disk); bool qemuDomainHasBlockjob(virDomainObjPtr vm, bool copy_only) ATTRIBUTE_NONNULL(1); diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e1e04beacb..536d7b5760 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17194,9 +17194,6 @@ qemuDomainBlockPullCommon(virQEMUDriverPtr driver, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (qemuDomainSupportsBlockJobs(vm) < 0) - goto endjob; - if (!(disk =3D qemuDomainDiskByName(vm->def, path))) goto endjob; @@ -17310,9 +17307,6 @@ qemuDomainBlockJobAbort(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (qemuDomainSupportsBlockJobs(vm) < 0) - goto endjob; - if (!(disk =3D qemuDomainDiskByName(vm->def, path))) goto endjob; @@ -17461,9 +17455,6 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (qemuDomainSupportsBlockJobs(vm) < 0) - goto endjob; - if (!(disk =3D virDomainDiskByName(vm->def, path, true))) { virReportError(VIR_ERR_INVALID_ARG, _("disk %s not found in the domain"), path); @@ -17545,9 +17536,6 @@ qemuDomainBlockJobSetSpeed(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (qemuDomainSupportsBlockJobs(vm) < 0) - goto endjob; - if (!(disk =3D qemuDomainDiskByName(vm->def, path))) goto endjob; --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list