From nobody Mon Feb 9 10:57:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562157693; cv=none; d=zoho.com; s=zohoarc; b=cKmoKdDh+Ng1zx+xImdpobB5ZFKG70ylQoBPYWxnGeZDQ3UU61fcFkiDuzO8b4V7zPRMHgVHtnX21x5pzPyZVrKPQHw2AsvumwTf4/64lbWeVffxtR5YtYipqCtJfQz7MNNYB4XSsF2AbRzHJWSYu8uLrUzbOpVey0THmlc+bTo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562157693; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Q/3uai1iSK75lb0c3WzrXKgTHh2oUd8VTTDSuInMpwM=; b=gOxFAjA9QBRgY/D4BPBxi/3bzrTjcdtgbX1Z42mwQlkPqndrifWf1y/Gm7OzjHCMuUEBPI1n3IRy4g9maPL3ktisDozo8vVxBaIQfe8+PchmAUqi0qrSajwSzwr1T/H8L8ZZH9n5sykw4ZhSWvk9i7XoUR0zTUc/Mmg2eWvkHDw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562157693088595.6214792637767; Wed, 3 Jul 2019 05:41:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C92BFA3B66; Wed, 3 Jul 2019 12:41:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91F815C29A; Wed, 3 Jul 2019 12:41:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 523DC18433A1; Wed, 3 Jul 2019 12:41:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x63CcEiP007720 for ; Wed, 3 Jul 2019 08:38:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9C818834EB; Wed, 3 Jul 2019 12:38:14 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2887F891D6 for ; Wed, 3 Jul 2019 12:38:14 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 3 Jul 2019 14:37:57 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 05/14] libxl: Drop support for parsing sxpr format in libxlConnectDomainXMLFromNative X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 03 Jul 2019 12:41:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We've dropped old xend support over a year ago. At this point we can also drop support for parsing very old configs. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- docs/drvxen.html.in | 3 +-- src/libxl/libxl_driver.c | 14 +++----------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/docs/drvxen.html.in b/docs/drvxen.html.in index ff67291ec6..b2f41c1763 100644 --- a/docs/drvxen.html.in +++ b/docs/drvxen.html.in @@ -58,8 +58,7 @@ xen+ssh://root@example.com/system (remote access, SSH tun= nelled) original Xen virtual machine config format used by the legacy xm/xend toolstack. The second, known as xen-sxpr, is also one of the original formats that was used by xend's - legacy HTTP RPC service. For compatibility, import and export - of these legacy formats is supported by the libxl driver. + legacy HTTP RPC service (removed in 5.6.0)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 2adb604f0f..7c236383e4 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -45,7 +45,6 @@ #include "libxl_capabilities.h" #include "libxl_migration.h" #include "xen_xm.h" -#include "xen_sxpr.h" #include "xen_xl.h" #include "virtypedparam.h" #include "viruri.h" @@ -2702,16 +2701,9 @@ libxlConnectDomainXMLFromNative(virConnectPtr conn, driver->xmlopt))) goto cleanup; } else if (STREQ(nativeFormat, XEN_CONFIG_FORMAT_SEXPR)) { - /* only support latest xend config format */ - if (!(def =3D xenParseSxprString(nativeConfig, - NULL, - -1, - cfg->caps, - driver->xmlopt))) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("parsing sxpr config failed")); - goto cleanup; - } + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("conversion from 'xen-sxpr' format is no longer s= upported")); + goto cleanup; } else { virReportError(VIR_ERR_INVALID_ARG, _("unsupported config type %s"), nativeFormat); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list