From nobody Sat Feb 7 09:47:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630784115; cv=none; d=zohomail.com; s=zohoarc; b=FbRex/iZuUJaH2kqVyGEbtk6Ida9KboR+aqjUTFqHDlHtaOJ2b4ShmgYi9YJM6fULflQNjPcvg9pQMYRmsmkiY13w5QuwIqBtF0W6qZFlmVarTgOM0k+ovAuV9Ab+fNK85/61HZSnXTeiIefIijO1Xu3uvTRvxLzu9/dsgAa1co= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630784115; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0N8g/2vlOjO0g+oRkE5G40AcmweOzrrf3Q4FhcvX3Hk=; b=A9lLrvwKmYj83m6mDQmKWgbfbnuAtAnT3EuqO7nJftRBtKD53h9dv9NAk9O9nq7uPJVA8i0rgWC+Zdc7zNbefqYk0Yc1paWzymwVWiavvk0g5JaqOy6nvDcjc00EuQ3mJoQpi9WLP51vSiXxwSGwah25bFKSOJatwRFLa/ac32E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1630784115315642.5470638246511; Sat, 4 Sep 2021 12:35:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-YsNAbbAWMbuaJarEo3aEzQ-1; Sat, 04 Sep 2021 15:35:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93DF71854E2A; Sat, 4 Sep 2021 19:35:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6EA3B19C59; Sat, 4 Sep 2021 19:35:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4039B180B44F; Sat, 4 Sep 2021 19:35:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 184JZ4Mo002579 for ; Sat, 4 Sep 2021 15:35:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 83E3C781ED; Sat, 4 Sep 2021 19:35:04 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E7BF77718 for ; Sat, 4 Sep 2021 19:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630784114; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0N8g/2vlOjO0g+oRkE5G40AcmweOzrrf3Q4FhcvX3Hk=; b=FGzQfNooZ7NChbSOlsmICNusCs+Fx6K/dcr2iGOZnJOl3I7pV1ZqDKGzFWGiEpEeeiIqMq QQ7SM1UEwPgy0q2iF1I1Rm7XQqg92QRXSBhwZXyvSuJhJzp/ilsO1Zs7LQSe+7S+ZK8TL1 uqWqgIRM3qwI3DR4LXW9ofHkqJUZ18o= X-MC-Unique: YsNAbbAWMbuaJarEo3aEzQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/6] tests: esxutils: reduce variable scope in testConvertWindows1252ToUTF8 Date: Sat, 4 Sep 2021 21:34:49 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630784116816100001 Also use g_auto. Signed-off-by: J=C3=A1n Tomko --- tests/esxutilstest.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c index d537da3011..db49dcd6e0 100644 --- a/tests/esxutilstest.c +++ b/tests/esxutilstest.c @@ -197,10 +197,9 @@ static int testConvertWindows1252ToUTF8(const void *data G_GNUC_UNUSED) { size_t i; - char *utf8 =3D NULL; =20 for (i =3D 0; i < G_N_ELEMENTS(windows1252ToUTF8); ++i) { - VIR_FREE(utf8); + g_autofree char *utf8 =3D NULL; =20 utf8 =3D virVMXConvertToUTF8("Windows-1252", windows1252ToUTF8[i].windows1252); @@ -208,13 +207,10 @@ testConvertWindows1252ToUTF8(const void *data G_GNUC_= UNUSED) if (utf8 =3D=3D NULL) return -1; =20 - if (STRNEQ(windows1252ToUTF8[i].utf8, utf8)) { - VIR_FREE(utf8); + if (STRNEQ(windows1252ToUTF8[i].utf8, utf8)) return -1; - } } =20 - VIR_FREE(utf8); return 0; } =20 --=20 2.31.1