From nobody Sun Feb 8 17:03:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1691591972; cv=none; d=zohomail.com; s=zohoarc; b=CYxPJJRUq5/QirRCqV9aZDWrhy1Zuzy5bvDS/TMTBnEAFEemQhomKxgUwfQTUJulRTeEs54EPnbsUaWvmyFWm4AIngJdJiAja3foXhKihm7mpcrT6LVcoGCBQBU7NxEJowVdz3guJLbVhWc6a1c6YaQLRAfz4X+4gMSnY7Uc4/0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691591972; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LGFXIGST60hT4I2erKYmHVI0SOGIhTBXi2Y0rqq/yUQ=; b=BhaPjIiO9sIPZ/TyLj3GXrD2s14g9MnmaoERVpBFZm6GhCsUYdUdulQiA7UkysTEaLOWDfPPhxW7QUqaoabupzlkUkHu0tN25TpbrLiFh+Glh9GBy3jsUgFquOXnVOD/Vr2TNmhD5QqS5J9UMLOeiMqW3ZbXIFPzCtSi2PlHeqw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1691591972253490.369449343455; Wed, 9 Aug 2023 07:39:32 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-TXujfBDCPPCUK86QXsTH4Q-1; Wed, 09 Aug 2023 10:39:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 485EE185A7A3; Wed, 9 Aug 2023 14:39:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9ACC140E96E; Wed, 9 Aug 2023 14:39:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A4A991946589; Wed, 9 Aug 2023 14:39:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8D4241946588 for ; Wed, 9 Aug 2023 14:14:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6D07A4A9005; Wed, 9 Aug 2023 14:14:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3E13401E30 for ; Wed, 9 Aug 2023 14:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691591971; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LGFXIGST60hT4I2erKYmHVI0SOGIhTBXi2Y0rqq/yUQ=; b=inK50xxSZ4Z7D+hN4aVeuR8Sk0zHTD/wXy1SJIQ1pATTGo44JvzTnwlj8Dir0kh7oehI8j cBM3feZuoHFABOnfXJ5zz9aKmePFfZmITgSMSL4SL/vc8yu45qGhZKIL3+ihUlR1MTP4E3 TKFj8lrwttyjxqpXE+Dyxiqe+1SpNqc= X-MC-Unique: TXujfBDCPPCUK86QXsTH4Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/4] qemuMigrationSrcBeginPhase: Properly report error when non-shared storage migration is requested over tunnel Date: Wed, 9 Aug 2023 16:14:20 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1691591973959100001 Content-Type: text/plain; charset="utf-8" When VIR_MIGRATE_TUNNELLED is used without VIR_MIGRATE_NON_SHARED_DISK/VIR_MIGRATE_NON_SHARED_INC an error was reported without actually returning failure. This was caused by a refactor which dropped many error paths. Fixes: 6111b235224 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index ed41a03851..a3fe6be4e9 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2617,6 +2617,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriver *driver, if (flags & VIR_MIGRATE_TUNNELLED) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("migration of non-shared storage is not suppo= rted with tunnelled migration and this QEMU")); + return NULL; } if (nmigrate_disks) { --=20 2.41.0